Payment keys are outdated

[flaimo]

payment keys have been changed to a strict yes/no/interval list. josm should be updated to reflect those changes in the autocomplete list of keys as well as affected presets (fuel for example).

see ​http://wiki.openstreetmap.org/wiki/Key:payment

[stoecker]

JOSM only uses checkboxes for payments (and thus yes/no only), so what do you request?

[flaimo]

1. it isn't used on the dialog for fuel stations, that was my mistake; i thought i saw it there. i checked again and it is used on the preset dialog for public transport vending machines for example. besides the fact that the current dialog produces tags that were also wrong after the old notation (payment:credit_cards=yes was never correct, since it expected a list of credit cards instead of "yes"), the checkboxes there should be changed to payment:visa, payment:mastercard, and so on… . see the wiki page for the current list of keys.
2. same thing for the keys in the autocomplete list when adding a new key/value entry. all keys that used to expect a list of entries as a value (payment:credit_cards, payment:debit_cards, …) now have been split up into yes/no keys (payment:visa, payment:maestro,…)

[anonymous]

See also #5900.

[flaimo]

ok, i went through the preset xml. i think the following payment lines should replace the old ones:

item name="Fuel"

      <space />
      <label text="Payment methods: Cash" />
      <check key="payment:coins" text="Coins" default="off" />
      <check key="payment:notes" text="Notes" default="off" />
      <check key="payment:cash" text="Cash (Shortcut for Coins and Notes)" default="on" />
      <space />
      <label text="Payment methods: Debit cards" />
      <check key="payment:maestro" text="Maestro" default="off" />
      <check key="payment:laser" text="Laser" default="off" />
      <space />
      <label text="Payment methods: Credit cards" />
      <check key="payment:mastercard" text="Mastercard" default="off" />
      <check key="payment:visa" text="Visa" default="off" />
      <check key="payment:american_express" text="American Express" default="off" />
      <check key="payment:discover_card" text="Discover Card" default="off" />
      <space />
     <label text="Payment methods: Fuel cards" />
      <check key="payment:dkv" text="DKV" default="off" />
      <check key="payment:uta" text="UTA" default="off" />
      <check key="payment:routex" text="Routex" default="off" />
      <check key="payment:roadrunner" text="Roadrunner" default="off" />
      <check key="payment:svg" text="SVG" default="off" />

item name="Ticket Machine"

      <label text="Payment methods: Cash" />
      <check key="payment:coins" text="Coins" default="off" />
      <check key="payment:notes" text="Notes" default="off" />
      <space />
      <label text="Payment methods: Debit cards" />
      <check key="payment:maestro" text="Maestro" default="off" />
      <check key="payment:laser" text="Laser" default="off" />
      <space />
      <label text="Payment methods: Credit cards" />
      <check key="payment:mastercard" text="Mastercard" default="off" />
      <check key="payment:visa" text="Visa" default="off" />
      <check key="payment:american_express" text="American Express" default="off" />
      <check key="payment:discover_card" text="Discover Card" default="off" />
      <space />
      <label text="Payment methods: Public transport" />
      <check key="payment:oyster" text="Oyster" default="off" />
      <check key="payment:bob" text="Bob" default="off" />

item name="Telephone"

      <label text="Payment methods: Cash" />
      <check key="payment:coins" text="Coins" default="off" />
      <check key="payment:notes" text="Notes" default="off" />
      <space />
      <label text="Payment methods: Debit cards" />
      <check key="payment:maestro" text="Maestro" default="off" />
      <check key="payment:laser" text="Laser" default="off" />
      <space />
      <label text="Payment methods: Credit cards" />
      <check key="payment:mastercard" text="Mastercard" default="off" />
      <check key="payment:visa" text="Visa" default="off" />
      <check key="payment:american_express" text="American Express" default="off" />
      <check key="payment:discover_card" text="Discover Card" default="off" />
      <space />
      <label text="Payment methods: Other" />
      <check key="payment:telephone_card" text="Telephone card" default="off" />

item name="Vending machine"

      <label text="Payment methods: Cash" />
      <check key="payment:coins" text="Coins" default="off" />
      <check key="payment:notes" text="Notes" default="off" />
      <space />
      <label text="Payment methods: Debit cards" />
      <check key="payment:maestro" text="Maestro" default="off" />
      <check key="payment:laser" text="Laser" default="off" />
      <space />
      <label text="Payment methods: Credit cards" />
      <check key="payment:mastercard" text="Mastercard" default="off" />
      <check key="payment:visa" text="Visa" default="off" />
      <check key="payment:american_express" text="American Express" default="off" />
      <check key="payment:discover_card" text="Discover Card" default="off" />

[stoecker]

Ticket #6272 has been marked as a duplicate of this ticket.

[skyper]

The list of different payment keys did grow.

• Do we need an own preset entry ?
  • How to handle country specific keys ?
• The preset for amenity=fuel will not fit on many screens if I would add payment keys. Is there a possibility to get two checkboxes in a column (#8735) ?