ERROR

[anonymous]

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if
possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-03-09 12:21:24
Last Changed Author: Upliner
Revision: 3966
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-03-09 11:48:50 +0100 (Wed, 09 Mar 2011)
Last Changed Rev: 3966

Identification: JOSM/1.5 (3966 es)
Memory Usage: 269 MB / 494 MB (33 MB allocated, but free)
Java version: 1.6.0_24, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows 7
Dataset consistency test: No problems found

Plugin: openstreetbugs (25540)
Plugin: turnrestrictions (25465)

java.lang.NullPointerException
	at org.openstreetmap.josm.io.Capabilities.isOnImageryBlacklist(Capabilities.java:140)
	at org.openstreetmap.josm.data.imagery.ImageryInfo.isBlacklisted(ImageryInfo.java:242)
	at org.openstreetmap.josm.actions.AddImageryLayerAction.updateEnabledState(AddImageryLayerAction.java:33)
	at org.openstreetmap.josm.actions.JosmAction$LayerChangeAdapter.layerAdded(JosmAction.java:201)
	at org.openstreetmap.josm.gui.MapView.fireLayerAdded(MapView.java:146)
	at org.openstreetmap.josm.gui.MapView.addLayer(MapView.java:281)
	at org.openstreetmap.josm.Main.addLayer(Main.java:267)
	at org.openstreetmap.josm.actions.AddImageryLayerAction.actionPerformed(AddImageryLayerAction.java:27)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown S

[stoecker]

In [4062/josm]:

fix #6267 - NPE

[bastiK]

In [4063/josm]:

see #6267, check for null

[stoecker]

You're sure your right bastiK? imageryBlacklist should never be null, as it is initialized in constructor.

[bastiK]

The NPE was thrown here: ​http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/io/Capabilities.java?rev=3934#L140

  if (url.matches(blacklistRegex)) {

so url can be null (for whatever reason).

Mjulius fixed this in ​http://josm.openstreetmap.de/changeset/3986/josm/trunk/src/org/openstreetmap/josm/io/Capabilities.java, so this should have been closed as duplicate in the first place

[stoecker]

OK, we were both wrong :-) Well, that's the issue when theoretically fixing bugs without actually testing.

[simon04]

Ticket #6183 has been marked as a duplicate of this ticket.