Opened 13 years ago

Last modified 12 years ago

#6189 new enhancement

Duplicate nodes in two un-closed ways

Reported by: bilbo Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: unconnected_way Cc:

Description (last modified by skyper)

In validator, there are two (or perhaps three) types of duplicates listed under "Duplicate nodes in two un-closed ways".

First are duplicates, where all nodes are part of some unclosed ways (this is what I expect to see there)

Second are duplicated nodes, where none of the nodes are part of any ways (basicaly duplicated POIs). These should be in a separate category (named something like "Duplicated nodes not in a way"), so you can distinguish those two apart.

Third could be nodes, where some of the nodes in the duplicate set are part of unclosed ways and some of them are not. I am not sure whether these should be put into first category, or have some separate category for it.
In real data this is often result of area with duplicated upload where you have removed duplicated ways (and any tagged nodes, like crossing, will be left behind) and if there is only one node from the duplicate set being part of some way, the fix is to delete all the others not being part of any way.

Second problem is that there is no "fix" button in this category (for myself I solved it with a patch, but perhaps others may like to use this feature too). There are many cases where you want to fix up some import, where either waterways or highways are uploaded in a manner that any crossings or connections do not share a node, but each way have private copy of node with same coordinate - there is no other function that will allow fixing those type of bugs. While there is risk of someone dumb damaging the data by connecting unrelated ways together, this Fix feature can be very useful (and safe), if you run it on result of validation of carefully selected subset of the data (complex search expressions can be good at selecting such subset)

Perhaps some heuristic as whether to enable fixing in this case or not is whether the validator was run on a selection different from all the data.

For Duplicated POIs there should be a button to automatically fix this type of bugs - since merging all the nodes basically mean delete all but one copy of the POI.

Technical note: there can be more duplicated nodes (and corresponding ways) than two, so the name should be "Duplicate nodes in _multiple_ un-closed ways"

Attachments (0)

Change History (2)

comment:1 by simon04, 12 years ago

Component: CoreCore validator
Type: defectenhancement

Please attach your patch.

comment:2 by skyper, 12 years ago

Description: modified (diff)
Keywords: unconnected_way added

Modify Ticket

Change Properties
Set your email in Preferences
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to bilbo.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.