Opened 13 years ago

Closed 13 years ago

#5954 closed enhancement (fixed)

Validator: please issue WARNING or ERROR for wrong coastline direction

Reported by: skela Owned by: team
Priority: normal Milestone:
Component: Core validator Version: tested
Keywords: validator, coastline Cc:


Currently, Validator checks coastline direction (land on the left side, sea on the right side of the line) only in the INFO level, which is not enabled by default.

Errors in coastline data can make rendering tools such as mkgmap --generate-sea misbehave seriously. In my humble opinion, the correctness of modified natural=coastline ways should be checked on every upload.

Attachments (0)

Change History (6)

comment:1 by stoecker, 13 years ago

Resolution: wontfix
Status: newclosed

The info level means that there are many false positives. Checking coastline is very error-prone, so we can't raise the level.

comment:2 by skela, 13 years ago

Sorry, I fail to see what is error-prone about checking that an island defined as a single way with natural=coastline has the right direction.

On a related note, the coastline checks already seem to take the bounding box into account. I no longer see bogus complaints about unclosed coastline when the unclosed end is outside the bounding box.

comment:3 by bastiK, 13 years ago

Resolution: wontfix
Status: closedreopened

stoecker: can you elaborate?

comment:4 by stoecker, 13 years ago

In general there have been too many warnings causing the info level. Maybe we can extract one warning into a higher level, but this needs testing.

comment:5 by simon04, 13 years ago

Component: CoreCore validator

Do we expect loads of false positives when raising "Reversed coastline: land not on left side" to the warning level?

comment:6 by simon04, 13 years ago

Resolution: fixed
Status: reopenedclosed

In [4505/josm]:

fix #5954 - validator: issue warning for wrong coastline/land direction

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.