Modify

Opened 9 years ago

Closed 8 years ago

#5953 closed defect (fixed)

[Patch] groynes are always considered as "areas"

Reported by: kellerma Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: Cc:

Description

Adding the tag "man_made=groyne" to a non-closed way leads to
a) immediately an area displayed
b) an error-message generated by the validator

However according to "Tag:man_made=groyne" in the wiki it's possilbe to have
non-closed ways as groynes so neither a) nor b) should happen.

Attachments (3)

5953.patch (765 bytes) - added by simon04 8 years ago.
5953_v2.patch (1.4 KB) - added by simon04 8 years ago.
5953_v3.patch (1.3 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by kellerma

Correction: according to wiki-page "Map_Features" groynes can be ways as well areas.

comment:2 Changed 9 years ago by kellerma

The same error we see for "leisure=track": shouldn't be an area.

Thank you.

Changed 8 years ago by simon04

Attachment: 5953.patch added

Changed 8 years ago by simon04

Attachment: 5953_v2.patch added

comment:3 Changed 8 years ago by simon04

Summary: groynes are always considered as "areas"[Patch] groynes are always considered as "areas"

This is due to some definitions in elemstyles.xml. The attached patch (_v2) resolves this issue for man_made=groyne as well as leisure=track.

comment:4 Changed 8 years ago by stoecker

This patch is wrong, Dropping area is an bug. You simply need to set closed="true", so unclosed ways aren't seen as area for this type anymore.

Changed 8 years ago by simon04

Attachment: 5953_v3.patch added

comment:5 Changed 8 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4292/josm]:

fix #5953 - patch by simon04 - fix some area/nonarea styles

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.