Going back from FullScreen triggers NPE

[avarab@…]

What steps will reproduce the problem?

1. Go to Full Screen under Debian / GNOME / Metacity
2. Try to go back
3. Get this NPE

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if
possible.

This is code that was changed in #5470. This worked before when I originally wrote this, so someone probably wasn't careful that "frame" wasn't NULL.

Build-Date: 2010-12-06 01:03:08
Revision: UNKNOWN
Is-Local-Build: true

Identification: JOSM/1.5 (UNKNOWN en)
Memory Usage: 15 MB / 989 MB (5 MB allocated, but free)
Java version: 1.6.0_22, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Linux


java.lang.NullPointerException
	at sun.awt.X11GraphicsDevice.setDisplayMode(X11GraphicsDevice.java:358)
	at sun.awt.X11GraphicsDevice.setFullScreenWindow(X11GraphicsDevice.java:300)
	at java.awt.Window$1DisposeAction.run(Window.java:997)
	at java.awt.Window.doDispose(Window.java:1026)
	at java.awt.Window.dispose(Window.java:973)
	at org.openstreetmap.josm.actions.FullscreenToggleAction.toggleSelectedState(FullscreenToggleAction.java:88)
	at org.openstreetmap.josm.actions.FullscreenToggleAction.actionPerformed(FullscreenToggleAction.java:118)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.JToggleButton$ToggleButtonModel.setPressed(JToggleButton.java:291)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:357)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1223)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1264)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
	at java.awt.Component.processMouseEvent(Component.java:6267)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6032)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4630)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[bastiK]

Hi avar!

Sorry for messing up your work. ;)

Full screen mode appeared the same way as maximized window on my system (Ubuntu/gnome) and Christian's (Win) so we tried to improve this.

Does it help to set draw.fullscreen.exclusive-mode=false?

Do you already have an idea for a fix?