Modify

Opened 9 years ago

Closed 8 years ago

#5706 closed defect (fixed)

[Patch needs rework] Role Verification Warnings

Reported by: rickmastfan67 Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Role Verification; validator Cc:

Description

This has been around for awhile, but the Validation Plugin (and even now when it's been merged into JOSM) has been throwing up a warning when you put any cardinal direction (north, south, east, west) into the role way of a relation.

Since the Validation Plugin is now part of JOSM, can we PLEASE get this verification bug eliminated?

If you haven't seen this happen before, just download the following relation (420779) as an example and run the Validation on it and you'll see it pop up the "north" and "south" role verification problem. That or just test the file I've attached where I've created an example using all four cardinal directions.

Attachments (3)

Route-Validation.osm (1.9 KB) - added by rickmastfan67 9 years ago.
Shows example of all four cardinal directions throwing up Warnings.
5706.patch (7.3 KB) - added by simon04 8 years ago.
5706.ignore-spaces.patch (3.9 KB) - added by simon04 8 years ago.
same as attachment:5706.patch, but ignoring whitespace for easier reviewing

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by rickmastfan67

Attachment: Route-Validation.osm added

Shows example of all four cardinal directions throwing up Warnings.

Changed 8 years ago by simon04

Attachment: 5706.patch added

Changed 8 years ago by simon04

Attachment: 5706.ignore-spaces.patch added

same as attachment:5706.patch, but ignoring whitespace for easier reviewing

comment:1 Changed 8 years ago by simon04

Summary: Role Verification Warnings[Patch] Role Verification Warnings

Patch attached. In order to group similar roles, allowed comma separated values in roles/role/@key in defaultpresets.xml. Please check for any bad side effects.

Last edited 8 years ago by simon04 (previous) (diff)

comment:2 Changed 8 years ago by stoecker

Summary: [Patch] Role Verification Warnings[Patch needs rework] Role Verification Warnings

The comma separation will break TaggingPresets.

I don't like these direction roles much. Probably we can add a new preset "Directional Route (America)" which has these tags.

comment:3 in reply to:  2 Changed 8 years ago by rickmastfan67

Replying to stoecker:

The comma separation will break TaggingPresets.

I don't like these direction roles much. Probably we can add a new preset "Directional Route (America)" which has these tags.

I would call it "Directional Route (North America)" since Canada uses the same roles as the USA. So does Mexico as far as I know.

comment:4 Changed 8 years ago by stoecker

Well, Canada and Mexiko are in North America or am I wrong?

comment:5 in reply to:  4 Changed 8 years ago by rickmastfan67

Replying to stoecker:

Well, Canada and Mexiko are in North America or am I wrong?

Well, you just said "America" and there are two continents that have "America" in the name. ;) hehe

To be honest, I have no idea how South America does their highways, hence the "Directional Route (North America)" suggestion. ;)

Last edited 8 years ago by rickmastfan67 (previous) (diff)

comment:6 Changed 8 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4367/josm]:

fix #5706 - support east/north/west/south for routes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.