Opened 13 years ago
Last modified 3 years ago
#5706 reopened defect
[Patch needs rework] Role Verification Warnings
Reported by: | rickmastfan67 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | Role Verification; validator | Cc: |
Description
This has been around for awhile, but the Validation Plugin (and even now when it's been merged into JOSM) has been throwing up a warning when you put any cardinal direction (north, south, east, west) into the role way of a relation.
Since the Validation Plugin is now part of JOSM, can we PLEASE get this verification bug eliminated?
If you haven't seen this happen before, just download the following relation (420779) as an example and run the Validation on it and you'll see it pop up the "north" and "south" role verification problem. That or just test the file I've attached where I've created an example using all four cardinal directions.
Attachments (3)
Change History (10)
by , 13 years ago
Attachment: | Route-Validation.osm added |
---|
by , 13 years ago
Attachment: | 5706.patch added |
---|
by , 13 years ago
Attachment: | 5706.ignore-spaces.patch added |
---|
same as attachment:5706.patch, but ignoring whitespace for easier reviewing
comment:1 by , 13 years ago
Summary: | Role Verification Warnings → [Patch] Role Verification Warnings |
---|
Patch attached. In order to group similar roles, allowed comma separated values in roles/role/@key
in defaultpresets.xml
. Please check for any bad side effects.
follow-up: 3 comment:2 by , 13 years ago
Summary: | [Patch] Role Verification Warnings → [Patch needs rework] Role Verification Warnings |
---|
The comma separation will break TaggingPresets.
I don't like these direction roles much. Probably we can add a new preset "Directional Route (America)" which has these tags.
comment:3 by , 13 years ago
Replying to stoecker:
The comma separation will break TaggingPresets.
I don't like these direction roles much. Probably we can add a new preset "Directional Route (America)" which has these tags.
I would call it "Directional Route (North America)" since Canada uses the same roles as the USA. So does Mexico as far as I know.
follow-up: 5 comment:4 by , 13 years ago
Well, Canada and Mexiko are in North America or am I wrong?
comment:5 by , 13 years ago
Replying to stoecker:
Well, Canada and Mexiko are in North America or am I wrong?
Well, you just said "America" and there are two continents that have "America" in the name. ;) hehe
To be honest, I have no idea how South America does their highways, hence the "Directional Route (North America)" suggestion. ;)
comment:7 by , 3 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This issue is still present.
For example, see relation 60815
Shows example of all four cardinal directions throwing up Warnings.