Opened 12 years ago
Closed 9 years ago
#5638 closed defect (fixed)
Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor
| Reported by: | rickmastfan67 | Owned by: | team |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Core | Version: | latest |
| Keywords: | Cc: |
Description
I have several plugins for JOSM installed here on my copy encase I ever need to use them. Because of that, the ones that are installed in the "Tools" menu make that menu too long to fully display on my monitor (1680x1050). Because of that, I can't select some that are in the menu, but below the bottom of my monitor, unless I know the shortcut for the tool (if it has one). (Yes, I know how to add items to my toolbar, but I don't use them that often to justify it.) Can there be a way to setup and allow the menu to spawn a second list right beside it if all the items in "Tools" can't be shown? Or how about make the icons smaller in that menu to allow more stuff to be shown (like in the Presets menu)? I know this would be more of a problem for people using a Laptop because of the limited space their screens have compared to my desktop. Just thought I would throw this out there. If you consider this a "enhancement", please go ahead and change the type of this report.
Attachments (3)
Change History (35)
Changed 12 years ago by
| Attachment: | Screenshot-long-Tools-menu.png added |
|---|
comment:2 Changed 12 years ago by
One step would be to remove the separations in the plugins. They only waste space.
comment:6 Changed 11 years ago by
http://tips4java.wordpress.com/2009/02/01/menu-scroller/ looks promising. However, the licence is unclear.
comment:9 Changed 11 years ago by
Replying to simon04:
http://tips4java.wordpress.com/2009/02/01/menu-scroller/ looks promising. However, the licence is unclear.
I like it, license shouldn't be a problem:
You are free to use and/or modify any or all code posted on the Java Tips Weblog without restriction. A credit in the code comments would be nice, but not in any way mandatory.
(http://tips4java.wordpress.com/about/)
Replying to stoecker:
The left handside toolbar has similar functionality already.
Yes, we have ScrollViewport class, but apart from the timer, there is not much similarity.
Changed 11 years ago by
| Attachment: | 5638.patch added |
|---|
comment:12 Changed 11 years ago by
| Summary: | Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor → [Patch] Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor |
|---|
I attempted to integrate MenuScroller, see the attached patch.
Currently, the number of items which are displayed at once is naïvely calculated by [screen height] / [height of New Layer]. Apart from that, MenuScroller seems to be working nicely.
comment:13 Changed 11 years ago by
Ticket #6019 ("preset list not scrollable") has been marked as a duplicate of this ticket.
comment:14 follow-up: 15 Changed 11 years ago by
There is a problem with the lower arrow button: It moves up and down, depending on the total height of the menu items.
The number of menu items is fixed. There are thin separators and larger items with an icon, so the total height varies, when there are more or less separators in the current view.
The whole approach to specify the number of menu items does not work when the items have different height. It should rather limit the total height of the scrolling menu section.
Anyway, the current patch is certainly an improvement of the current state.
comment:15 follow-up: 18 Changed 11 years ago by
Replying to bastiK:
It should rather limit the total height of the scrolling menu section.
That shouldn't be too hard to implement – I'll take a look at it.
comment:17 Changed 11 years ago by
Using the screen height might be a problem when using multiple screens …
comment:18 follow-up: 19 Changed 11 years ago by
It should rather limit the total height of the scrolling menu section.
That shouldn't be too hard to implement – I'll take a look at it.
The change is harder than expected as scrollCount is used in several methods. I didn't want to rework all of them at the moment.
For now, we could add the current implementation and refine it afterwards?
comment:19 Changed 11 years ago by
Replying to simon04:
It should rather limit the total height of the scrolling menu section.
That shouldn't be too hard to implement – I'll take a look at it.
The change is harder than expected as
scrollCountis used in several methods. I didn't want to rework all of them at the moment.
Why not comment out or remove the unused methods?
For now, we could add the current implementation and refine it afterwards?
Sure.
comment:23 Changed 11 years ago by
As the stable version was released, I suggest that I commit my patch from above. Some drawbacks already have been discussed.
comment:26 Changed 11 years ago by
comment:27 Changed 11 years ago by
It seems to work OK on 800x600, only small feature would be better to improve:
often menu expands one line more then needed (not only for last item):
Changed 11 years ago by
| Attachment: | Screenshot800x600.png added |
|---|
comment:28 Changed 11 years ago by
| Summary: | [Patch] Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor → Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor |
|---|
comment:30 Changed 11 years ago by
It works almost perfectly, so maybe someone should close the ticket?
comment:32 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
We have now a lot more of different menus (Tools, More Tools, Data, etc.)
example for a long tools menu when some plugins are installed