Modify

Opened 9 years ago

Closed 9 years ago

#5570 closed enhancement (fixed)

[PATCH] Brightness/transparency of WMS layer control

Reported by: jekhor Owned by: team
Priority: normal Milestone:
Component: Core imagery Version:
Keywords: Cc: Upliner

Description (last modified by jekhor)

Sometimes WMS layers are too bright and this makes map data layers almost unreadable. Some kind of control WMS layer brightness or transparency will be useful.

Attachments (4)

transparency.png (434 bytes) - added by bastiK 9 years ago.
Created an icon. Not too good, but maybe its a start…
eye-translucent.png (1.2 KB) - added by Upliner 9 years ago.
half-transparent dithered eye icon
opacity.diff (18.7 KB) - added by Upliner 9 years ago.
eye-pressed.png (931 bytes) - added by Upliner 9 years ago.
Make the pressed button translucent too

Download all attachments as: .zip

Change History (18)

comment:1 Changed 9 years ago by jekhor

Description: modified (diff)

comment:2 Changed 9 years ago by Upliner

I wrote a patch that allows to change opacity of any layer

comment:3 Changed 9 years ago by bastiK

Summary: Brightness/transparency of WMS layer control[PATCH] Brightness/transparency of WMS layer control

comment:4 Changed 9 years ago by bastiK

Technically it looks good, but we should improve the GUI a little. My idea would be to merge it somehow with the visibility switch ("eye") because it's a special case of transparency (0% and 100%).

Then some visual feedback would be good. Currently it shows a red cross on the layer icon for 100% transparency. Maybe we can come up with some gradual display?

comment:5 in reply to:  4 Changed 9 years ago by Upliner

Replying to bastiK:

Technically it looks good, but we should improve the GUI a little.

Yes, I should at least draw an icon for new button.

My idea would be to merge it somehow with the visibility switch ("eye") because it's a special case of transparency (0% and 100%).

How do you see it? If you offer something specific, I'll do it.

comment:6 Changed 9 years ago by bastiK

Sorry it took so long to answer. I have a bigger change in mind and haven't found time to do a prototype, yet. The basic idea is to make the list entry symbols clickable like in gimp image software. Then you can add a transparency slider button next to the eye button field. We could have an extra column for active layer at the left, so the importance of "active layer" is more clear.

Last edited 9 years ago by bastiK (previous) (diff)

comment:7 Changed 9 years ago by bastiK

Ok, I did the changes I had in mind ([3661]).

  • My suggestion would be to (practically) remove the visible field from Layer.java. A layer is invisible when the opacity value is 0 and it is opaque when this value is 1.
  • A click on show/hide changes the opacity value to 1 in case it is < 1 and to 0 otherwise.
  • It should be clearly (and directly) visible, whether a layer is opaque, or just 99% visible. (Because there is a considerable performance loss for half-transparent layers.)
  • The easiest way would be to change the new "eye" symbol in the layer list depending on the opacity value:
    • invisible and opaque like it is now.
    • another symbol that represents all opacity values > 0 and < 1. (E.g. the "eye" symbol, but half transparent.)

Changed 9 years ago by bastiK

Attachment: transparency.png added

Created an icon. Not too good, but maybe its a start...

comment:8 Changed 9 years ago by Upliner

Cc: Upliner added

I'm sorry for long response too... I don't want remove the visible field because current implementation has a nice feature: it remembers opacity level for hidden layers. I.e I can hide a half-transparent layer and then show it again with same transparency level. I't exteamly convenient for me when viewing the OSM tiles over the Bing imagery. Clicking at eye icon is much easier than moving a slider.

Last edited 9 years ago by Upliner (previous) (diff)

comment:9 Changed 9 years ago by bastiK

I see your point. I'd like to show some symbol in the corresponding line of the layer list, whenever the opacity is different from 100%. Any ideas?

Changed 9 years ago by Upliner

Attachment: eye-translucent.png added

half-transparent dithered eye icon

comment:10 Changed 9 years ago by Upliner

Maybe just show a half-transparent dithered eye icon like that? I know that dithering is kind-of out of fashion, I just don't have an another idea...

comment:11 Changed 9 years ago by bastiK

ok, this will get in after next release, i'll come up with something...

comment:12 Changed 9 years ago by bastiK

Problem with the half transparent eye: User is used to toggle sequence: closed, open, closed, open, ...

now he/she changes transparency and it is: blurred, closed, blurred, closed, ...

so the question would come, how do i get it back to 100% opaque? (Right, move transparency slider to 100%)

comment:13 in reply to:  12 Changed 9 years ago by Upliner

Replying to bastiK:

Problem with the half transparent eye: User is used to toggle sequence: closed, open, closed, open, ...

I don't see a big problem here. If user already have moved a slider why he can't move it again? I think it's a situation where any solutions would have some drawbacks...

My solution seems to be quite efficient: transparency is often used for imagery layers and user usually don't need more than one fully opaque imagery layer, however he/she might want to temorary disable some of half-transparent layers.

Changed 9 years ago by Upliner

Attachment: opacity.diff added

Changed 9 years ago by Upliner

Attachment: eye-pressed.png added

Make the pressed button translucent too

comment:14 Changed 9 years ago by Upliner

Resolution: fixed
Status: newclosed

In [3705/josm]:

applied #5570 - implement layer opacity control

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.