Modify

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#5183 closed enhancement (fixed)

Select AND zoom on validation error when double clicking

Reported by: echokilo17@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

This is an enhancement proposal:

When you search for errors using the Validator plugin, it returns a list of errors/warnings/etc. If you want to work on something it detected you need to double click the error (this selects the ways/nodes) and then right-click the error and click on "Zoom on error". This is an unnecessarily complicated workflow.

My proposal is that double clicking on an error will do both: select the "faulty" ways and zoom on it so that you can effectively work on fixing the potential error.

Attachments (0)

Change History (6)

comment:1 by echokilo17@…, 14 years ago

Forgot to add that the version of the plugin is 21667

comment:2 by stoecker, 14 years ago

Resolution: wontfix
Status: newclosed

It is not always wanted to zoom on the objects. You can press 3 instead of right click+select, which makes workflow much easier. This is not the first time this is suggested and I think it also was implemented for some time, but with this suggestion you can't support the cases, where zooming is unwanted, whereas the current form allows people to do both.

comment:3 by e2jk, 14 years ago

Resolution: wontfix
Status: closedreopened

OK, I get the idea. Maybe that could be an option then, no?

To give you an idea, I am busy with importing buildings from the French cadastre. In a small city (Chaumont, 27 159 inhabitants) I uploaded 70871 nodes and 12355 ways (i.e. around 12355 buildings). Of those buildings, Validator told me 160 were overlapping, so I needed to fix those buildings. For each building I had to double click, right click and click again (4 clicks in total), so 640 clicks just to select and see the error, whereas I could have saved half if there was auto-zooming.

I am aware that this might be specific to my current workflow, and I can imagine other people not wanting to auto-zoom, but if this option was available it would have served me well (and would serve me on the next imports I'm working on, there are still a lot of buildings to import in France ;) )

I guess that if it was implemented for some time, it could be retrieved from the code repository, and I imagine adding an option could be done, right? I am no JOSM developer, so it is difficult for me to get an idea of the difficulty of doing this, but it seems to be doable. Your opinion on this, stoecker?

I'm reopening this issue as I don't know if you will receive an email.

comment:4 by e2jk, 14 years ago

BTW, if this request had already been done, it would mean that other people need this too. You know the stories about the ratio of people taking time to report bugs and all the others sitting in the dark ;)

comment:5 by stoecker, 14 years ago

Resolution: fixed
Status: reopenedclosed

Why don't you press "3"? It's easy enough.

In [o22004] I added hidden option "validator.autozoom".

comment:6 by e2jk, 14 years ago

Because double-clicking and then pressing 3 makes me use both the mouse and the keyboard. I've tested the "validator.autozoom" option and it works great, thanks a lot!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.