Opened 14 years ago
Closed 14 years ago
#5182 closed enhancement (fixed)
[PATCH] Conflict system simplification
| Reported by: | Upliner | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core | Version: | |
| Keywords: | Cc: | jttt, bastiK |
Description
Conflicts in "visible" property is quite misleading. I think that user shouldn't decide whether a primitive should be considered as "visible" or not. User should have only two choices to delete the primitive(or do nothing if it's already deleted) or to keep it(or undelete it if it have been deleted). Since JOSM now supports proper handling of "invisible" objects we can do such simpification. And there are no more need for special purge or undelete command(However, we may need the latter one again if API behavor changes).
Attachments (1)
Change History (7)
by , 14 years ago
| Attachment: | conflicts.diff added |
|---|
comment:2 by , 14 years ago
PurgePrimitivesCommand can still be used for a purge command feature that was requested multiple times. But I see, it is not removed by this patch.
comment:3 by , 14 years ago
NOTE that code which is not referenced in JOSM is also not included in nightly builds. So effectively it is removed.
comment:4 by , 14 years ago
I support the general idea of the patch. (Remove visibility conflict and don't create new primitives for undelete.)
comment:6 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The patch to get rid of visibility conflicts