Modify

Opened 9 years ago

Closed 9 years ago

#5182 closed enhancement (fixed)

[PATCH] Conflict system simplification

Reported by: Upliner Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc: jttt, bastiK

Description

Conflicts in "visible" property is quite misleading. I think that user shouldn't decide whether a primitive should be considered as "visible" or not. User should have only two choices to delete the primitive(or do nothing if it's already deleted) or to keep it(or undelete it if it have been deleted). Since JOSM now supports proper handling of "invisible" objects we can do such simpification. And there are no more need for special purge or undelete command(However, we may need the latter one again if API behavor changes).

Attachments (1)

conflicts.diff (47.0 KB) - added by Upliner 9 years ago.
The patch to get rid of visibility conflicts

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Upliner

Attachment: conflicts.diff added

The patch to get rid of visibility conflicts

comment:1 Changed 9 years ago by stoecker

Cc: jttt bastiK added

Someone wants to review this as well?

comment:2 Changed 9 years ago by bastiK

PurgePrimitivesCommand can still be used for a purge command feature that was requested multiple times. But I see, it is not removed by this patch.

comment:3 Changed 9 years ago by stoecker

NOTE that code which is not referenced in JOSM is also not included in nightly builds. So effectively it is removed.

comment:4 Changed 9 years ago by bastiK

I support the general idea of the patch. (Remove visibility conflict and don't create new primitives for undelete.)

comment:5 Changed 9 years ago by bastiK

What is the state for this change?

comment:6 Changed 9 years ago by stoecker

Resolution: fixed
Status: newclosed

(In [3362]) fix #5182 - Conflict system simplification - patch by Upliner

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.