Modify ↓

Opened 14 years ago

Closed 14 years ago

#4115 closed defect (fixed)

[Patch] JoinAreasAction whines about ways not being inside the downloaded area when editing a new OSM file

Reported by: avarab@… Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

  1. Ctrl+n
  2. Create overlapping areas
  3. Join areas
  4. JOSM complains about the ways being outside the downloaded area, but I'm editing a new file

The code seems to have been copied from simply way action so perhaps it has the same problem.

Attachments (2)

JoinAreasOutsideBoundary.patch​ (4.7 KB) - added by mjulius 14 years ago.
JoinAreasOutsideBoundary2.patch​ (7.3 KB) - added by mjulius 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 14 years ago by anonymous

The attached patch fixes this issue.

Eventually this should be changed so that the message only pops up when there are nodes outside the download area that are actually being deleted.

Changed 14 years ago by mjulius

Attachment: JoinAreasOutsideBoundary.patch​ added

comment:2 Changed 14 years ago by mjulius

Summary: JoinAreasAction whines about ways not being inside the downloaded area when editing a new OSM file → [Patch] JoinAreasAction whines about ways not being inside the downloaded area when editing a new OSM file

comment:3 Changed 14 years ago by mjulius

The second patch changes the DataSet.getSelected*() methods to actually return collections of the appropriate primitive types instead of Collection<OsmPrimitive>. Also, it simplifies JoinAreasAction.actionPerformed().

Changed 14 years ago by mjulius

Attachment: JoinAreasOutsideBoundary2.patch​ added

comment:4 Changed 14 years ago by mjulius

Resolution: → fixed
Status: new → closed

(In [2610]) Fixes #4115 - bogus warning about nodes outside download area in JoinAreasAction
DataSet.getSelected*() now return collections of the proper primitive type

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.