Modify

Opened 10 years ago

Closed 10 years ago

Last modified 2 months ago

#4088 closed enhancement (fixed)

Remove modified flag when merging downloaded data

Reported by: stoecker Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

When new server data is downloaded and the merging process shows an object is flagged as modified, but identical to to server data, then modified should be removed.

Notes:

  • Ensure Undo/Redo set modify again
  • Be sure data is really unmodified
  • Offer to download all modified primitives before upload?

This should reduce the number of useless changed elements a lot (at least when download before upload is done).

Attachments (0)

Change History (4)

comment:1 Changed 10 years ago by mjulius

Resolution: fixed
Status: newclosed

(In [2624]) fixes #4088,#4155 - when after conflict resolving the primitive has equal semantic attributes as theirs, the primitive will get the same modified flag as theirs.

comment:2 Changed 10 years ago by stoecker

Resolution: fixed
Status: closedreopened

Sorry, but you did not fix this issue.

You can test it like that:

  • add a new node to a way
  • delete that node again --> you get a useless modified state
  • redownload area --> still useless modified state

comment:3 Changed 10 years ago by mjulius

Resolution: fixed
Status: reopenedclosed

(In [2634]) really fixes #4088 - Remove modified flag when merging downloaded data

comment:4 Changed 2 months ago by Don-vip

In 15444/josm:

fix #18212, see #4088, see #4155 - don't override modified flag of deleted primitives after resolving a conflict

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.