#3750 closed enhancement (worksforme)
Error in relation (combine ways)
| Reported by: | anonymous | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core | Version: | latest |
| Keywords: | combine ways relation member | Cc: |
Description
When I combine two ways in the same relation I have the new way twice in the relation.
Sorry for my bad english.
Attachments (3)
Change History (8)
by , 16 years ago
by , 16 years ago
| Attachment: | after_split.jpg added |
|---|
by , 16 years ago
| Attachment: | after_combine.jpg added |
|---|
comment:1 by , 16 years ago
follow-up: 3 comment:2 by , 16 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
This is a feature, not a defect.
In general, it it hardly possible to decide automatically, whether both memberships should be kept or not and which of the memberships should be deleted, if only one is kept.
That's why a conflict dialog is displayed. The default is to keep all relation memberships in such a way, that they keep to resulting combined way.
comment:3 by , 16 years ago
| Keywords: | combine relation member added; combyne removed |
|---|---|
| Resolution: | wontfix |
| Status: | closed → reopened |
| Type: | defect → enhancement |
Replying to Gubaer:
This is a feature, not a defect.
Really? Sometimes, I truly wonder whether JOSM coders are mappers at all, but I try to stay an optimist.
In general, it it hardly possible to decide automatically, whether both memberships should be kept or not and which of the memberships should be deleted, if only one is kept.
That's why a conflict dialog is displayed. The default is to keep all relation memberships in such a way, that they keep to resulting combined way.
This is a case of merging two ways, both of which are a member of this relation, that have no role conflict. It makes no sense, no sense at all, after the merge, to have the same way as a member twice.
I appreciate the conflict dialog has a place, when there is ambiguity in the roles of the members before they were joined. This is not the case for most simple merges. If someone really wants the merged way in the relation twice, it's not hard to achieve, but it's my strong feeling that you're disturbing the editing flow in most cases.
In reality, this ticket is very related to #3463, so if you want to close one and fix the other, that's fine.
comment:4 by , 15 years ago
| Resolution: | → worksforme |
|---|---|
| Status: | reopened → closed |
This does seem to work as one would expect. When combining two ways which are members of the same relation the dialog pops up where one can choose the membership of the original ways. There one defaults to keep and the other to remove.
comment:5 by , 15 years ago
Sure, since this was opened 17 months ago, a lot has happened, and this got fixed.
Also see #3463 http://josm.openstreetmap.de/ticket/3463#comment:8