Modify

Opened 10 years ago

Closed 8 years ago

#3751 closed defect (fixed)

[patch] Illegal tag/value combinations test doesn't tell me what tag/values can't be combined

Reported by: avarab@… Owned by: stoecker
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: Cc: delta_foxtrot2

Description

This test is practically useless to me. Often it's reporting on nodes with >10 key-value pairs and I have no idea what key-value pairs don't belong since it doesn't tell me that.

It should indicate what key-value pairs don't go together in the UI somehow.

Attachments (2)

illegal-tag-value-combo.png (41.9 KB) - added by avarab@… 10 years ago.
Where's the tooltip describing what's wrong here?
3751.patch (991 bytes) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by stoecker

There is a additional description text telling you more about the problem. If you don't see it for some reason, the tooltip should contain it also.

Changed 10 years ago by avarab@…

Attachment: illegal-tag-value-combo.png added

Where's the tooltip describing what's wrong here?

comment:2 Changed 10 years ago by stoecker

Owner: changed from team to delta_foxtrot2

Introduced with #2803.

Delta-Foxtrot, it seems your patch somehow does not work as expected.

comment:3 Changed 10 years ago by delta_foxtrot2

Cc: delta_foxtrot2 added
Owner: changed from delta_foxtrot2 to stoecker

I don't see how the patch in #2803 is relevent to this bug, #2803 made the validator plugin ignore invalid errors even if they weren't in the preset list, it doesn't generate the error listed in this ticket, in fact it suppresses warning from being shown.

comment:4 Changed 10 years ago by stoecker

These warnings are issued from code added by "validator2.patch". These are additional warnings and probably not exactly what you wanted to do.

comment:5 Changed 10 years ago by delta_foxtrot2

It doesn't look like my code, it's probably been copied from somewhere else when I was coding the patch.

comment:6 Changed 10 years ago by stoecker

                if(!ignore) 
                { 
                    errors.add( new TestError(this, Severity.ERROR, tr("Illegal tag/value combinations"), 
                    tr("Illegal tag/value combinations"), tr("Illegal tag/value combinations"), 1272, p) ); 
                    withErrors.add(p, "TC"); 
                } 

Nah, it wasn't there before and also 1272 is not a correct error ID. This is new code. I tried to fix it, but I did not fully understand how it should work at all. Currently it will add a new error when one of the twokey parts is found, but not one of the other ones.

comment:7 Changed 8 years ago by simon04

In the meanwhile, this is mostly fixed, right?

If sensible, one could augment the "unusual tag combination" by the corresponding tags (cf. patch).

Changed 8 years ago by simon04

Attachment: 3751.patch added

comment:8 Changed 8 years ago by stoecker

Summary: Illegal tag/value combinations test doesn't tell me what tag/values can't be combined[patch] Illegal tag/value combinations test doesn't tell me what tag/values can't be combined

comment:9 Changed 8 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4296/josm]:

fix #3751 - patch by simon04 - Illegal tag/value combinations test doesn't tell me what tag/values can't be combined

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain stoecker.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.