Opened 14 years ago
Closed 13 years ago
#3751 closed defect (fixed)
[patch] Illegal tag/value combinations test doesn't tell me what tag/values can't be combined
Reported by: | Owned by: | stoecker | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | latest |
Keywords: | Cc: | delta_foxtrot2 |
Description
This test is practically useless to me. Often it's reporting on nodes with >10 key-value pairs and I have no idea what key-value pairs don't belong since it doesn't tell me that.
It should indicate what key-value pairs don't go together in the UI somehow.
Attachments (2)
Change History (11)
comment:1 by , 14 years ago
by , 14 years ago
Attachment: | illegal-tag-value-combo.png added |
---|
Where's the tooltip describing what's wrong here?
comment:2 by , 14 years ago
Owner: | changed from | to
---|
Introduced with #2803.
Delta-Foxtrot, it seems your patch somehow does not work as expected.
comment:3 by , 14 years ago
Cc: | added |
---|---|
Owner: | changed from | to
comment:4 by , 14 years ago
These warnings are issued from code added by "validator2.patch". These are additional warnings and probably not exactly what you wanted to do.
comment:5 by , 14 years ago
It doesn't look like my code, it's probably been copied from somewhere else when I was coding the patch.
comment:6 by , 14 years ago
if(!ignore) { errors.add( new TestError(this, Severity.ERROR, tr("Illegal tag/value combinations"), tr("Illegal tag/value combinations"), tr("Illegal tag/value combinations"), 1272, p) ); withErrors.add(p, "TC"); }
Nah, it wasn't there before and also 1272 is not a correct error ID. This is new code. I tried to fix it, but I did not fully understand how it should work at all. Currently it will add a new error when one of the twokey parts is found, but not one of the other ones.
comment:7 by , 13 years ago
In the meanwhile, this is mostly fixed, right?
If sensible, one could augment the "unusual tag combination" by the corresponding tags (cf. patch).
by , 13 years ago
Attachment: | 3751.patch added |
---|
comment:8 by , 13 years ago
Summary: | Illegal tag/value combinations test doesn't tell me what tag/values can't be combined → [patch] Illegal tag/value combinations test doesn't tell me what tag/values can't be combined |
---|
There is a additional description text telling you more about the problem. If you don't see it for some reason, the tooltip should contain it also.