Opened 13 years ago
Closed 11 years ago
#3751 closed defect (fixed)
[patch] Illegal tag/value combinations test doesn't tell me what tag/values can't be combined
Reported by: | Owned by: | stoecker | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | latest |
Keywords: | Cc: | delta_foxtrot2 |
Description
This test is practically useless to me. Often it's reporting on nodes with >10 key-value pairs and I have no idea what key-value pairs don't belong since it doesn't tell me that.
It should indicate what key-value pairs don't go together in the UI somehow.
Attachments (2)
Change History (11)
comment:1 Changed 13 years ago by
Changed 13 years ago by
Attachment: | illegal-tag-value-combo.png added |
---|
Where's the tooltip describing what's wrong here?
comment:2 Changed 13 years ago by
Owner: | changed from team to delta_foxtrot2 |
---|
Introduced with #2803.
Delta-Foxtrot, it seems your patch somehow does not work as expected.
comment:3 Changed 13 years ago by
Cc: | delta_foxtrot2 added |
---|---|
Owner: | changed from delta_foxtrot2 to stoecker |
comment:4 Changed 13 years ago by
These warnings are issued from code added by "validator2.patch". These are additional warnings and probably not exactly what you wanted to do.
comment:5 Changed 13 years ago by
It doesn't look like my code, it's probably been copied from somewhere else when I was coding the patch.
comment:6 Changed 13 years ago by
if(!ignore) { errors.add( new TestError(this, Severity.ERROR, tr("Illegal tag/value combinations"), tr("Illegal tag/value combinations"), tr("Illegal tag/value combinations"), 1272, p) ); withErrors.add(p, "TC"); }
Nah, it wasn't there before and also 1272 is not a correct error ID. This is new code. I tried to fix it, but I did not fully understand how it should work at all. Currently it will add a new error when one of the twokey parts is found, but not one of the other ones.
comment:7 Changed 11 years ago by
In the meanwhile, this is mostly fixed, right?
If sensible, one could augment the "unusual tag combination" by the corresponding tags (cf. patch).
Changed 11 years ago by
Attachment: | 3751.patch added |
---|
comment:8 Changed 11 years ago by
Summary: | Illegal tag/value combinations test doesn't tell me what tag/values can't be combined → [patch] Illegal tag/value combinations test doesn't tell me what tag/values can't be combined |
---|
There is a additional description text telling you more about the problem. If you don't see it for some reason, the tooltip should contain it also.