[patch] Illegal tag/value combinations test doesn't tell me what tag/values can't be combined

[avarab@…]

This test is practically useless to me. Often it's reporting on nodes with >10 key-value pairs and I have no idea what key-value pairs don't belong since it doesn't tell me that.

It should indicate what key-value pairs don't go together in the UI somehow.

[stoecker]

There is a additional description text telling you more about the problem. If you don't see it for some reason, the tooltip should contain it also.

[avarab@…]

Where's the tooltip describing what's wrong here?

[stoecker]

Introduced with #2803.

Delta-Foxtrot, it seems your patch somehow does not work as expected.

[delta_foxtrot2]

I don't see how the patch in #2803 is relevent to this bug, #2803 made the validator plugin ignore invalid errors even if they weren't in the preset list, it doesn't generate the error listed in this ticket, in fact it suppresses warning from being shown.

[stoecker]

These warnings are issued from code added by "validator2.patch". These are additional warnings and probably not exactly what you wanted to do.

[delta_foxtrot2]

It doesn't look like my code, it's probably been copied from somewhere else when I was coding the patch.

[stoecker]

                if(!ignore) 
                { 
                    errors.add( new TestError(this, Severity.ERROR, tr("Illegal tag/value combinations"), 
                    tr("Illegal tag/value combinations"), tr("Illegal tag/value combinations"), 1272, p) ); 
                    withErrors.add(p, "TC"); 
                } 

Nah, it wasn't there before and also 1272 is not a correct error ID. This is new code. I tried to fix it, but I did not fully understand how it should work at all. Currently it will add a new error when one of the twokey parts is found, but not one of the other ones.

[simon04]

In the meanwhile, this is mostly fixed, right?

If sensible, one could augment the "unusual tag combination" by the corresponding tags (cf. patch).

[stoecker]

In [4296/josm]:

fix #3751 - patch by simon04 - Illegal tag/value combinations test doesn't tell me what tag/values can't be combined