Modify

Opened 12 years ago

Closed 11 years ago

#3463 closed enhancement (fixed)

Combine ways conflict resolution for relations

Reported by: Ldp Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc: malenki

Description

I'm trying to combine two ways which are both a member of the same 5 relations. The combine dialog in r2097 only shows me one of those relations*

When I still combine the two ways, the relation member counts aren't updated. On looking at them, the relation that was shown in the combine dialog now has *two* copies of the resulting combined way.

The other 4 relations still show the old situation, with both the resulting combined way and the *deleted* way. I don't dare to try an upload, but I presume this will come back as a precondition failed from the api.

  • In r2094 it still showed all 5, twice, but the combine action itself didn't do anything.

Attachments (3)

2-ways-5-relations.osm (1.9 KB) - added by Gubaer 12 years ago.
2-ways-5-relations-2101-result.osm (1.8 KB) - added by Ldp 12 years ago.
Result of merging the example with r2101
2-ways-5-relations.out.osm (1.8 KB) - added by Gubaer 12 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by malenki

Cc: malenki added

comment:2 Changed 12 years ago by Ldp

Summary: Combine ways action doesn't properly update relationsCombine ways action breaks relations

comment:3 Changed 12 years ago by Gubaer

It would be very helpful if you could post a sample OSM file.

comment:4 Changed 12 years ago by Gubaer

(In [2100]) see #3463: Combine ways action breaks relations

comment:5 Changed 12 years ago by Gubaer

(In [2101]) see #3463: Combine ways action breaks relations

Changed 12 years ago by Gubaer

Attachment: 2-ways-5-relations.osm added

comment:6 Changed 12 years ago by Gubaer

Resolution: fixed
Status: newclosed

I've found and fixed a silly bug.

I can successfully combine the the two ways in the attached sample file, both of them being member of the same five relations. I think it should be OK now. Otherwise let me know.

Changed 12 years ago by Ldp

Result of merging the example with r2101

comment:7 Changed 12 years ago by Ldp

I combined the two ways in your example with 2101, and the resulting file describes what experienced before.

The relations still refer to way -6, which is gone, because it got merged into way -4.

Changed 12 years ago by Gubaer

Attachment: 2-ways-5-relations.out.osm added

comment:8 Changed 12 years ago by Ldp

Priority: criticalnormal
Resolution: fixed
Status: closedreopened
Summary: Combine ways action breaks relationsCombine ways conflict resolution for relations
Type: defectenhancement

Yes, should've tested with r2103 which had the actual change.

So r2103 has a change which causes all involved relations to show up again in the combine conflict dialog, and when I merge the ways, the relations are updated, to replace the occurences of way -6 with the remaining way -4. This is like your 2-ways-5-relations.out.osm. Out goes Priority: Critical, since the relations are legal again.

But I still reopened, but downgraded, because the combining ways action should not create duplicate members in the relation by default. If I merge 2 ways, I expect that only the resulting way remains in the relation, and only once at that. It should not replace way -6 with way -4, but it should only remove way -6. The conflict resolution dialog sets all member actions to replace, but wouldn't it be more logical to preset one decision to replace, the other to remove? That would make it work just like it used to.

Only where the roles would conflict, should both decisions be preset to replace, so the user can sort it out.

Forward/backward conflict resolution could be automated for certain cases:

-F->-F-> => -F----->
-F->-B-> => ask user
-B->-F-> => ask user
-B->-B-> => -B----->

-F-><-B- => -F----->
-F-><-F- => aks user
-B-><-F- => -B----->
-B-><-B- => ask user

comment:9 Changed 11 years ago by Ldp

Resolution: fixed
Status: reopenedclosed

This has been fixed in the meantime, and merging ways that are both a member of the same relation now correctly sets 1 to Keep and 1 to Remove.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.