varying behaviour using Enter and Escape

[malenki]

At different dialogs in Josm Enter and Escape are handled differently.
For example in in the settings-dialog Escape cancels the dialog, Enter submits changes.

At the uploading-dialog hitting Enter and Escape results in nothing. One has to use tab and spacebar or the mouse to cancel or submit changes.

The same keys should everywhere cause the same reaction of the program.

Besides it would be useful if after editing the changeset-comment hitting enter would result in uploading => better workflow. Or should I file another ticket that for?

[Gubaer]

Besides it would be useful if after editing the changeset-comment hitting enter would result in uploading => better workflow. Or should I file another ticket that for?

What about moving focus to the "OK" button after enter in the changeset-comment and then start uploading on a second enter? This is in my opinion less surprising to users.

[xeen]

Hm. Esc not working looks like an ExtendedDialog bug to me. I've looked at it, but the code doesn't seem to have changed when I originally wrote it and I have no idea why it should have stopped working…

[malenki]

Both enter and escape now work with the upload-dialog. Uploading after commenting and hitting two times entr is so smoooth! :)

If the fact, that the PicLayer-Help doesn't close when ESC is hit is a bug just of the plugin, this ticket can be closed.

Thanks for your work!
malenki

[malenki]

Right now I experienced that the GPS-log-upload can be started with either space or enter, but closed only with space...

[Cobra]

There are still some dialogs where enter/esc has no effect.

• unsaved changes - save/upload before deleting
• delete object from relation
• conflict when combining ways

[Cobra]

This is still a fundamental issue, with an increasing number of dialogs being affected. I'll try to make a current list in the next days.

[Don-vip]

Replying to Cobra:

This is still a fundamental issue, with an increasing number of dialogs being affected. I'll try to make a current list in the next days.

Thanks, this will be appreciated :)

[Cobra]

affected dialogs and the respective unhandled keys:

• (api) conflict dialog (enter, esc)
• tag conflict dialog (enter, esc) (when combining ways or merging nodes)

(to be continued)

[skyper]

• OAuth diaologs (enter)

[Cobra]

• reverter plugin dialog (enter, esc) (not in core, but same issue)

[skyper]

• preference dialog
  • plugins > plugins (enter)
  • even with OK selected through TAB