Modify

Opened 9 years ago

Last modified 8 months ago

#3464 new defect

varying behaviour using Enter and Escape

Reported by: malenki Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description (last modified by Cobra)

At different dialogs in Josm Enter and Escape are handled differently.
For example in in the settings-dialog Escape cancels the dialog, Enter submits changes.

At the uploading-dialog hitting Enter and Escape results in nothing. One has to use tab and spacebar or the mouse to cancel or submit changes.

The same keys should everywhere cause the same reaction of the program.

Besides it would be useful if after editing the changeset-comment hitting enter would result in uploading => better workflow. Or should I file another ticket that for?

Attachments (0)

Change History (11)

comment:1 Changed 9 years ago by Gubaer

Besides it would be useful if after editing the changeset-comment hitting enter would result in uploading => better workflow. Or should I file another ticket that for?

What about moving focus to the "OK" button after enter in the changeset-comment and then start uploading on a second enter? This is in my opinion less surprising to users.

comment:2 Changed 9 years ago by xeen

Hm. Esc not working looks like an ExtendedDialog bug to me. I've looked at it, but the code doesn't seem to have changed when I originally wrote it and I have no idea why it should have stopped working…

comment:3 Changed 9 years ago by malenki

Both enter and escape now work with the upload-dialog. Uploading after commenting and hitting two times entr is so smoooth! :)

If the fact, that the PicLayer-Help doesn't close when ESC is hit is a bug just of the plugin, this ticket can be closed.

Thanks for your work!
malenki

comment:4 Changed 9 years ago by malenki

Right now I experienced that the GPS-log-upload can be started with either space or enter, but closed only with space...

comment:5 Changed 7 years ago by Cobra

There are still some dialogs where enter/esc has no effect.

  • unsaved changes - save/upload before deleting
  • delete object from relation
  • conflict when combining ways

comment:6 Changed 6 years ago by Cobra

Description: modified (diff)

This is still a fundamental issue, with an increasing number of dialogs being affected. I'll try to make a current list in the next days.

comment:7 in reply to:  6 Changed 6 years ago by Don-vip

Replying to Cobra:

This is still a fundamental issue, with an increasing number of dialogs being affected. I'll try to make a current list in the next days.

Thanks, this will be appreciated :)

comment:8 Changed 6 years ago by Cobra

affected dialogs and the respective unhandled keys:

  • (api) conflict dialog (enter, esc)
  • tag conflict dialog (enter, esc) (when combining ways or merging nodes)

(to be continued)

Last edited 6 years ago by Cobra (previous) (diff)

comment:9 Changed 6 years ago by skyper

  • OAuth diaologs (enter)

comment:10 Changed 6 years ago by Cobra

  • reverter plugin dialog (enter, esc) (not in core, but same issue)

comment:11 Changed 5 years ago by skyper

  • preference dialog
    • plugins > plugins (enter)
    • even with OK selected through TAB

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to malenki
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.