Modify

Opened 11 years ago

Closed 11 years ago

#3669 closed enhancement (fixed)

[PATCH] Ignore NodesWithSameName with unique ref

Reported by: skela Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: patch NodesWithSameName Cc:

Description

There tend to be many bus or tram stops by the same name. When all the equally named nodes carry unique ref attributes, NodesWithSameName should not complain. This would reduce noise (false positives).

A further enhancement would be to somehow take operator=* into account, but this could be tricky, since both operator and ref are optional. It might also be useful to take the node type into account and not complain if bus, train or tram stops or parking places or rental stations all share the same street or place name.

Attachments (1)

NodesWithSameName.patch (1.7 KB) - added by skela 11 years ago.
Patch to ignore same-name nodes with unique ref

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by skela

Attachment: NodesWithSameName.patch added

Patch to ignore same-name nodes with unique ref

comment:1 Changed 11 years ago by stoecker

Actually I think that check should be dropped totally. It was invented for the GeoNames import and is probably outdated a lot nowadays.

comment:2 in reply to:  1 Changed 11 years ago by skela

Replying to stoecker:

Actually I think that check should be dropped totally. It was invented for the GeoNames import and is probably outdated a lot nowadays.

I think that the check still is somewhat useful, because it can highlight bus stops with missing ref. Having validator generate a separate list of these “search results” could be a little nicer than repeatedly searching for “highway=bus_stop ref=”. Also, checking for duplicate place=* or shop=* names is still useful.
(I think that shops should be tagged not just name='Chain' but name='Chain Location'. When the location is part of the shop name (and it usually is if you look at the sales slip), it will be easier to read the list of nearby POIs in a navigator.)

comment:3 Changed 11 years ago by skela

Resolution: fixed
Status: newclosed

I realized that I do have commit access to the OpenStreetMap repository, where the JOSM plugins are stored. Because I am convinced that this patch is not breaking anything and it is silencing bogus warnings for me, I took the liberty of committing the patch.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.