[PATCH] Infinite loop in relation editor

[Daeron]

There's a remote possibility for an infinite loop in the relation editor in the linkedness checking.

If the relation itself (or a relation containing it as first or last member) is added as the first member, or it is added multiple times in the relation, the code tries to infinitely traverse the sub-relations.

This patch fixes the bug by checking that the sub-relation is not the relation itself.

[anonymous]

Actually that does not fix the problem. You should either check against all sub-relations which have been before or add a depth break count (e.g. 10).

[Daeron]

Yes, you are right. I didn't consider the possibility that the added relation might already contain a loop in itself.

Attached new patch adds also a depth check.

[stoecker]

In r1624.