Changeset 1624 in josm

Timestamp:

2009-05-28T17:49:08+02:00 (15 years ago)

Author:

stoecker

Message:

fix #2654 - patch by Daeron - Infinite loop in relation editor

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java

@@ -341 +341 @@
             RelationMember way1 = null;
             RelationMember way2 = null;
-            while (m != null) {
+            int depth = 0;
+
+            while (m != null && depth < 10) {
                 if (m.member instanceof Way) {
                     way1 = m;
                     break;
                 } else if (m.member instanceof Relation) {
+                    if (m.member == this.relation)
+                        break;
                     m = ((Relation)m.member).lastMember();
+                    depth++;
                 } else {
                     break;
@@ -355 +360 @@
                 while (next < clone.members.size()) {
                     m = clone.members.get(next++);
-                    while (m != null) {
+                    depth = 0;
+                    while (m != null && depth < 10) {
                         if (m.member instanceof Way) {
                             way2 = m;
                             break;
                         } else if (m.member instanceof Relation) {
+                            if (m.member == this.relation)
+                                break;
                             m = ((Relation)(m.member)).firstMember();
+                            depth++;
                         } else {
                             break;