Opened 16 years ago
Closed 16 years ago
#2530 closed defect (fixed)
Plugin list update broken with newest Trac version
Reported by: | Owned by: | team | |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | plugin | Cc: |
Description
The list of available plugins does not update correctly using the latest stable release (1566).
When checking JOSM's preferences (Mac vocabulary), Plugin tab. It only shows those plugins that has been installed since before, see attached image.
Clicking the Download list button confirms that plugins has been downloaded from 1 site. But clicking the Update button will still not populate the plugin list with all available plugins.
The plugin site I use is: http://josm.openstreetmap.de/wiki/Plugins (default?)
Another indication:
~./josm/plugins/0-site-http_josm.openstreetmap.de_wiki_Plugins.xml
This file is empty between the plugins-tag.
Attachments (2)
Change History (23)
by , 16 years ago
Attachment: | nonpopulatedpluginlist.png added |
---|
comment:1 by , 16 years ago
Keywords: | plugin added |
---|---|
Version: | tested → latest |
Have the same problem with latest-1566, I only get a message that plugin list downloaded from 1 site, but the list is completely blank. Windows XP.
comment:2 by , 16 years ago
I can also confirm this issue after a clean build of the latest (1569) svn revision on a brand new system. Ubuntu Jaunty, OpenJDK.
comment:3 by , 16 years ago
Summary: | Plugin list does not populate → Plugin list update broken with newest Trac version |
---|
The plugin list download is broken as the HTML is no longer parsed correctly. It gets time to switch to the new plugin information dataset (http://josm.openstreetmap.de/plugin) instead of fixing the old stuff again.
by , 16 years ago
Attachment: | PluginDownloader.patch added |
---|
Fix the regex that patches http://josm.openstreetmap.de/wiki/Plugins
comment:5 by , 16 years ago
Summary: | Plugin list update broken with newest Trac version → [PATCH] Plugin list update broken with newest Trac version |
---|
attachment:PluginDownloader.patch fixes this issue. It doesn't implement parsing the new manifest file but fixes the regex that parses the trac page.
comment:15 by , 16 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I have tried out this fix, and have found that it does not work under windows. I get an error about reading:
0-site-http_josm.openstreetmap.de_plugin.txt
The fix works fine under linux.
comment:16 by , 16 years ago
Just tested with r1588 on WinXP using a fresh profile. No problems at all. Only using an older profile causes this error:
org.openstreetmap.josm.plugins.PluginException: Ein Fehler ist in dem Plugin colorscheme aufgetreten. at org.openstreetmap.josm.plugins.PluginInformation.<init>(PluginInformation.java:137) at org.openstreetmap.josm.plugins.PluginSelection.getAvailablePlugins(PluginSelection.java:293) at org.openstreetmap.josm.plugins.PluginSelection.drawPanel(PluginSelection.java:131) at org.openstreetmap.josm.plugins.PluginSelection.updateDescription(PluginSelection.java:57) at org.openstreetmap.josm.gui.preferences.PluginPreference$1.actionPerformed(PluginPreference.java:46) at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.setPressed(Unknown Source) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source) at java.awt.Component.processMouseEvent(Unknown Source) at javax.swing.JComponent.processMouseEvent(Unknown Source) at java.awt.Component.processEvent(Unknown Source) [ snip ] at java.awt.Dialog.setVisible(Unknown Source) at org.openstreetmap.josm.actions.PreferencesAction.actionPerformed(PreferencesAction.java:73) at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) [ snip ] at java.awt.EventDispatchThread.run(Unknown Source) Caused by: java.io.IOException: line too long at java.util.jar.Attributes.read(Unknown Source) at java.util.jar.Manifest.read(Unknown Source) at org.openstreetmap.josm.plugins.PluginInformation.<init>(PluginInformation.java:77) ... 63 more
BTW: I do not have a plugin named "colorscheme" installed. The plugin directory contains:
AgPifoJ.jar
openstreetbugs.jar
remotecontrol.jar
slippymap.jar
usertools.jar
utilsplugin.jar
validator.jar
wmsplugin.jar
comment:17 by , 16 years ago
I got that same Java exception backtrace, but I was not able to see the full list of plugins
Steps to reproduce:
- Delete C:\Documents and Settings\<username>\Application Data\JOSM
- Start JOSM
- Edit > Preferences > Plugins > Download List
I was able to download the two plugins that appeared on the list I got.
My command line was:
"C:\Program Files\Java\jre1.6.0_07\bin\java.exe" -jar "C:\Program Files\josm\josm-snapshot-1588.jar"
comment:19 by , 16 years ago
Summary: | [PATCH] Plugin list update broken with newest Trac version → Plugin list update broken with newest Trac version |
---|
comment:20 by , 16 years ago
The error indicates that probably the parsing of the plugin list goes wrong. Something is still buggy here.
comment:21 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Should be fixed in r1591.
Screenshot