cycleway=asl not on cycleway - incorrect validator warning

[LordGarySugar]

What steps will reproduce the problem?

1. place a cycleway=asl node on a highway=secondary or other road
2. validate
3. validator warning 'suspicious tag combination - cycleway=asl not on cycleway' is highlighted

What is the expected result?

No validator warning should be shown

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

I believe this is a regression, I have only noticed this validator warning in the last few months

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2026-01-31 13:00:34 +0100 (Sat, 31 Jan 2026)
Revision:19481
Build-Date:2026-02-01 02:30:45
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19481 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 22H2 (19045)
Memory Usage: 760 MB / 8176 MB (155 MB allocated, but free)
Java version: 21.0.9+10-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 2560x1440x32bpp@165Hz (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=C:\Program Files\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (36474)
+ HouseNumberTaggingTool (36474)
+ PicLayer (271)
+ apache-commons (36474)
+ buildings_tools (36474)
+ gridify (39)
+ imagery_offset_db (36474)
+ jaxb (36474)
+ jogl (1.2.3)
+ log4j (36474)
+ markseen (178)
+ measurement (36474)
+ pmtiles (36474)
+ reltoolbox (36474)
+ reverter (36474)
+ terracer (36474)
+ todo (157)
+ turnlanes (36474)
+ urbaneye3d (1.7.0)
+ utilsplugin2 (36474)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/HighwayAreas&zip=1

Last errors/warnings:
- 00739.196 W: java.io.IOException: Attribution is not loaded yet
- 00739.196 W: java.io.IOException: Attribution is not loaded yet
- 00739.196 W: java.io.IOException: Attribution is not loaded yet
- 00739.196 W: java.io.IOException: Attribution is not loaded yet
- 00739.196 W: java.io.IOException: Attribution is not loaded yet
- 00739.196 W: java.io.IOException: Attribution is not loaded yet
- 00739.197 W: java.io.IOException: Attribution is not loaded yet
- 00739.197 W: java.io.IOException: Attribution is not loaded yet
- 00739.197 W: java.io.IOException: Attribution is not loaded yet
- 00739.197 W: java.io.IOException: Attribution is not loaded yet

[rswarbrick@…]

This warning is new and was added to josm with revision r19475. The check is in resources/data/validator/combinations.mapcss and you can see the diff here:

https://josm.openstreetmap.de/changeset?reponame=josm&new=19475%40trunk%2Fresources%2Fdata%2Fvalidator%2Fcombinations.mapcss&old=19468%40trunk%2Fresources%2Fdata%2Fvalidator%2Fcombinations.mapcss

The relevant code is this:

/* #21927 */
way[!cycleway][!cycleway:right][!cycleway:left][!cycleway:both][!cycleway:lanes] > node[cycleway=asl] {
  throwWarning: tr("{0} not on cycleway", "{0.tag}");
  group: tr("suspicious tag combination");
}

and it means that there will be a complaint if an ASL node is added to a road without an explicit cycleway tag.

Reading ​https://wiki.openstreetmap.org/wiki/Tag:cycleway=asl carefully, I think the code change might have been wrong.

The commit is marked as fixing ticket #21927 (a feature request to check that an ASL says which direction of the way it applies to). I think that check is done in the code added just below the code that triggers the warning at issue in this ticket.

@stoecker: I think the change is yours. Does this sound correct to you?

(PS: I'm really sorry if I've mangled something in this reply or contradicted any norms: I spend my life in GitHub, so trac is a rather foreign environment to me!)