Modify

Opened 2 years ago

Last modified 2 years ago

#21927 new enhancement

[Patch] Add optional direction tag to cycleway=asl preset

Reported by: Woazboat Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: asl direction Cc:

Description (last modified by taylor.smock)

cycleway=asl should also be tagged with the corresponding direction unless it's a oneway street (similar to highway=stop/give_way)
osmwiki:Tag:cycleway=asl

Attachments (1)

cycleway_asl_direction_2022-02-11.patch (857 bytes ) - added by Woazboat 2 years ago.
Add optional direction tag to cycleway=asl preset

Download all attachments as: .zip

Change History (6)

by Woazboat, 2 years ago

Add optional direction tag to cycleway=asl preset

comment:1 by taylor.smock, 2 years ago

Description: modified (diff)

From the wiki page:

If it is not a oneway the a direction tag is needed. Use key direction=* for this. Values are forward or backward. Example: direction=forward

Why do you have N,E,S,W,0,90,180,270,forward,backward as possible values for direction in the patch? It looks like it should just be forward,backward.

comment:2 by Woazboat, 2 years ago

I added those in order to be consistent with the josm presets for highway=stop and highway=give_way which have the same semantics as cycleway=asl. (Although I'm not sure why exactly those additional values are defined there. They should all be removed tbh.)

comment:3 by skyper, 2 years ago

direction=forward/backward is a complete mess. I consider both values as tagging for a router. Many of the asl I know are the end of a cycle lane and the highway needs to be split at the asl.
If we change the values, we should add more cardinal values like NE or 45.

comment:4 by skyper, 2 years ago

Component: CoreInternal preset
Keywords: asl direction added

comment:5 by Emvee, 2 years ago

See taginfo, cycleway=asl is currently only mapped with direction=forward/backward

Also for highway=stop and highway=give_way you can do the math and see that only 1.8 and 2.7% is mapped as not forward/backward and very likely that remaining percentage is "both" but that makes no/much less sense for cycleway=asl.

What is messy about direction=forward/backward? Yes, it is tagging for the router but is that bad? The only problem I know is that direction on a node does not make sense without looking at the way context. That can be a problem if the node is part of multiple ways and josm is warning for that. It is no problem if direction of the ways are consistent and my guesstimate is that this is often the case so I think the problem is small.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to Woazboat.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.