Opened 4 years ago
Last modified 3 days ago
#21927 new enhancement
[Patch] Add optional direction tag to cycleway=asl preset
| Reported by: | Woazboat | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 25.10 |
| Component: | Internal preset | Version: | |
| Keywords: | asl direction | Cc: |
Description (last modified by )
cycleway=asl should also be tagged with the corresponding direction unless it's a oneway street (similar to highway=stop/give_way)
osmwiki:Tag:cycleway=asl
Attachments (2)
Change History (9)
by , 4 years ago
| Attachment: | cycleway_asl_direction_2022-02-11.patch added |
|---|
comment:1 by , 4 years ago
| Description: | modified (diff) |
|---|
From the wiki page:
If it is not a oneway the a direction tag is needed. Use key direction=* for this. Values are forward or backward. Example: direction=forward
Why do you have N,E,S,W,0,90,180,270,forward,backward as possible values for direction in the patch? It looks like it should just be forward,backward.
comment:2 by , 4 years ago
I added those in order to be consistent with the josm presets for highway=stop and highway=give_way which have the same semantics as cycleway=asl. (Although I'm not sure why exactly those additional values are defined there. They should all be removed tbh.)
comment:3 by , 4 years ago
direction=forward/backward is a complete mess. I consider both values as tagging for a router. Many of the asl I know are the end of a cycle lane and the highway needs to be split at the asl.
If we change the values, we should add more cardinal values like NE or 45.
comment:4 by , 4 years ago
| Component: | Core → Internal preset |
|---|---|
| Keywords: | asl direction added |
comment:5 by , 4 years ago
See taginfo, cycleway=asl is currently only mapped with direction=forward/backward
Also for highway=stop and highway=give_way you can do the math and see that only 1.8 and 2.7% is mapped as not forward/backward and very likely that remaining percentage is "both" but that makes no/much less sense for cycleway=asl.
What is messy about direction=forward/backward? Yes, it is tagging for the router but is that bad? The only problem I know is that direction on a node does not make sense without looking at the way context. That can be a problem if the node is part of multiple ways and josm is warning for that. It is no problem if direction of the ways are consistent and my guesstimate is that this is often the case so I think the problem is small.
by , 4 days ago
| Attachment: | cycleway_asl_direction_2.patch added |
|---|
Reduce directions to forward and backward, and add validation rules
comment:6 by , 4 days ago
Hello, I apologize if it is improper to bump an issue from 2022, please let me know and I can move to a new issue if needed.
I was doing some updates to cycleways involving advanced stop lines and noticed this open issue. If there is still interest in possibly adding direction to the cycleway=asl preset, I attached a new patch (cycleway_asl_direction_2.patch) based on Woazboat's original patch, but incorporating the feedback about direction, and adding some validation rules for cycleway=asl.
comment:7 by , 3 days ago
| Milestone: | → 25.10 |
|---|



Add optional direction tag to cycleway=asl preset