Opened 3 months ago
Closed 3 months ago
#24091 closed task (fixed)
Drop gradle for JOSM managed plugins
| Reported by: | stoecker | Owned by: | taylor.smock |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin | Version: | |
| Keywords: | Cc: |
Description
Hi Taylor,
- MicrosoftStreetside
- Mapillary
- wikipedia
- areaselector
- PicLayer
- indoorhelper
- pt_assistant
- validations_testing
still has gradle build stuff.
I'd vote to drop that and only leave ant/maven. I probably anyway broke these for pt_assistant and wikipedia with the I18n changes.
You probably know better than me what's to do to finally get rid of this.
DevelopersGuide/DevelopingPlugins
and
DevelopersGuide/Compiling
probably should also be adapted.
Attachments (0)
Change History (10)
comment:1 by , 3 months ago
comment:2 by , 3 months ago
Translations stuff is fixed. I ported everything and deleted the outdated transifex stuff. Only build issues and GitHub task updates should remain.
comment:3 by , 3 months ago
In that case, yes, it should be fairly easy to drop the gradle scripts. I'll go through and check the GH CI scripts though -- they may need to be updated.
comment:4 by , 3 months ago
I checked validations_testing and there at least the plugin information must be transferred from gradle to ant/maven files.
comment:5 by , 3 months ago
P.S. And yes, the transfer of the translations was some hours work yesterday ;-) But Transifex translations are mostly outdated/unmanaged, so there is no need for any transition period.
comment:7 by , 3 months ago
Done:
- indoorhelper
- validations_testing
- MicrosoftStreetside
- wikipedia
- areaselector
- PicLayer
- pt_assistant
They've also had auto releases set up. I need to check the URLs on PluginsSource though.
comment:8 by , 3 months ago
Is there any reason why not all JOSM-GitHub release links could be /latest/?
comment:9 by , 3 months ago
Not as far as I know. I was going to go through them once I finished removing gradle in Mapillary.
Note: /latest/ isn't quite the same URL layout as the pinned versions.
comment:10 by , 3 months ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The i18n stuff is probably going to be the "big" issue. I don't know what all of them use for i18n (specifically, the ones on GH). I think they are highly likely to use transifex for their translations.
I know Mapillary, MicrosoftStreetside, and validations_testing won't be an issue, and I can just remove the gradle files there.
What we should do first is drop/comment out source:osm/applications/editors/josm/i18n/build.xml@36370:56-84#L56, then give translators a chance to catch up (e.g. 6 months -- during this period, we can still use the translations from transifex), and finally remove .tx directories from the plugins we control.