[PATCH] Improve java version detection in /usr/bin/josm

[ZLima12]

Previously, the first line of output from the java -version command was assumed to be the version string, but this is not guaranteed. For example, when the _JAVA_OPTIONS environment variable is not empty, a "Picked up _JAVA_OPTIONS" message is printed before the version string. When this happens, java_version produces an empty string, which later results in some java options not being passed to the JVM.

[skyper]

I do not think your patch works with other java distributions than openjdk or does it? For sure both tested and latest need to be fixed and your current patch only handles the former.

How do you install and start JOSM? Where do you set the environment options?

[wangi]

A more portable patch could have not redirected stderr to stdout, thereby avoiding the Picked up _JAVA_OPTIONS being passed to head and awk. Or grep -v _JAVA_OPTIONS...

I've also seen this suggested:

_SILENT_JAVA_OPTIONS="$_JAVA_OPTIONS"
unset _JAVA_OPTIONS
alias java='java "$_SILENT_JAVA_OPTIONS"'