Modify

Opened 7 months ago

Last modified 7 months ago

#23965 needinfo defect

IAE: Way is already deleted (Delete command) (Way not properly removed after merging buildings)

Reported by: hun.30d@… Owned by: hun.30d@…
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

Unknown

Please provide any additional information below. Attach a screenshot if possible.

When uploading changes the JSOM validator was showing an entry of "Overlapping buildings", but there was only one building at that place. When I tried to delete the remaining building way is when the exception happened.

I checked some nodes of the building, advanced object info shows that some nodes are part of two or three ways:
Node: 3025339969

Part of:

Way: 298638242
Way: 298638256

Node: 3025339957

Part of:

Way: -20278
Way: 298638242
Way: 298638256

Previously i merged 3 building ways at that place: 298638256 was the remaining one, 298638242 and 298638253 was deleted during the merge.

Creating new nodes on the way and merging them into the old nodes fixed the problem.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-10-01 13:50:10 +0200 (Tue, 01 Oct 2024)
Revision:19230
Build-Date:2024-10-02 01:30:34
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19230 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro N 21H2 (19044)
Memory Usage: 1060 MB / 4082 MB (602 MB allocated, but free)
Java version: 21.0.3+9-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ PicLayer (1.0.3)
+ imagery_offset_db (36344)

Last errors/warnings:
- 01660.961 W: java.io.IOException: Attribution is not loaded yet
- 01660.961 W: java.io.IOException: Attribution is not loaded yet
- 01660.961 W: java.io.IOException: Attribution is not loaded yet
- 01660.962 W: java.io.IOException: Attribution is not loaded yet
- 01660.962 W: java.io.IOException: Attribution is not loaded yet
- 01660.962 W: java.io.IOException: Attribution is not loaded yet
- 01660.962 W: java.io.IOException: Attribution is not loaded yet
- 448013.704 W: Conflicts detected - <html>There were 2 conflicts detected.</html>
- 448720.465 W: Warning - <html>The data to be uploaded participates in unresolved conflicts of layer '1244444444.osc'.<br>You have to resolve them first.</html>
- 603728.710 E: Handled by bug report queue: java.lang.IllegalArgumentException: {Way id=298638253 version=1 MVDT nodes=[{Node id=3025339998 version=1 MV lat=47.77132303326677,lon=19.146044479063033}, {Node id=3025339993 version=1 MV lat=47.77130717945325,lon=19.14614353050213}, {Node id=3025339976 version=1 MV lat=47.77124770038686,lon=19.146122454893465}, {Node id=3025339998 version=1 MV lat=47.77132303326677,lon=19.146044479063033}]} is already deleted



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-1 (41) of JOSM
java.lang.IllegalArgumentException: {Way id=298638253 version=1 MVDT nodes=[{Node id=3025339998 version=1 MV lat=47.77132303326677,lon=19.146044479063033}, {Node id=3025339993 version=1 MV lat=47.77130717945325,lon=19.14614353050213}, {Node id=3025339976 version=1 MV lat=47.77124770038686,lon=19.146122454893465}, {Node id=3025339998 version=1 MV lat=47.77132303326677,lon=19.146044479063033}]} is already deleted
	at org.openstreetmap.josm.command.DeleteCommand.lambda$executeCommand$0(DeleteCommand.java:211)
	at org.openstreetmap.josm.data.osm.DataSet.update(DataSet.java:1065)
	at org.openstreetmap.josm.command.DeleteCommand.executeCommand(DeleteCommand.java:207)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:300)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:354)
	at org.openstreetmap.josm.actions.mapmode.DeleteAction.doActionPerformed(DeleteAction.java:164)
	at org.openstreetmap.josm.actions.DeleteAction.actionPerformed(DeleteAction.java:86)
	at java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810)
	at java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2956)
	at java.desktop/javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:309)
	at java.desktop/javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:264)
	at java.desktop/javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:3049)
	at java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:3041)
	at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2918)
	at java.desktop/java.awt.Component.processEvent(Component.java:6398)
	at java.desktop/java.awt.Container.processEvent(Container.java:2266)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4996)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4828)
	at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1952)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:883)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1146)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1020)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:848)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4877)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4828)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:775)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:98)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:747)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:744)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Attachments (1)

osc.zip (6.8 KB ) - added by babfa <hun.30d@…> 7 months ago.

Download all attachments as: .zip

Change History (4)

in reply to:  description comment:1 by skyper, 7 months ago

Summary: Way not properly removed after merging buildingsIAE: Way is already deleted (Delete command) (Way not properly removed after merging buildings)

Probably a duplicate of #16206.

Replying to hun.30d@…:

- 448013.704 W: Conflicts detected - <html>There were 2 conflicts detected.</html>
- 448720.465 W: Warning - <html>The data to be uploaded participates in unresolved conflicts of layer '1244444444.osc'.<br>You have to resolve them first.</html>
- 603728.710 E: Handled by bug report queue: java.lang.IllegalArgumentException: {Way id=298638253 version=1 MVDT nodes=[{Node id=3025339998 version=1 MV lat=47.77132303326677,lon=19.146044479063033}, {Node id=3025339993 version=1 MV lat=47.77130717945325,lon=19.14614353050213}, {Node id=3025339976 version=1 MV lat=47.77124770038686,lon=19.146122454893465}, {Node id=3025339998 version=1 MV lat=47.77132303326677,lon=19.146044479063033}]} is already deleted

It looks like a file 1244444444.osc was loaded and another layer or only some objects from another layer were merged resulting in conflicts. We probably need to know your decisions to solve the conflicts, if it is a problem with the conflict manager.
Is there a reliable way to reproduce? If so, please, attach the layers and share a step by step description with more details.

by babfa <hun.30d@…>, 7 months ago

Attachment: osc.zip added

comment:2 by babfa, 7 months ago

I cannot reproduce it because it probably involved some uploads. I opened the 1244444444.osc file some days ago, since then I have opened other files too. I usually edit in Vespucci first then export to OSC and finish it in JOSM.

A week or so ago I opened 1244444444.osc then used "Download data..." to download the surrounding area to the new layer the file created, then I did some edits probably and uploaded it. That change (via the .osc file) added addr:* tags to way 298638256.

More recently I merged some buildings to that way in Vespucci then exported 10112.osc. Opened it in JOSM, used "Download data" again, then, after some modifications (i think i only moved that building way) tried to upload it, and thats when the validator brought up the "Overlapping buildings" issue with the broken building.

By this time the old layer that was created when opening 1244444444.osc was deleted, I did not merge it to other layers manually. However I did not reopen JOSM, so its the same running instance that handled that file.

I tried loading these files again but the bug probably happened when I downloaded data from OSM, and the data from the server is different now because I uploaded some changes since then. Also tried messing around with an .osc file generated at https://revert.monicz.dev/ but couldn't reproduce anything.

The changes were:
1244444444.osc -> https://www.openstreetmap.org/changeset/157512063
10112.osc -> https://www.openstreetmap.org/changeset/157792580

comment:3 by taylor.smock, 7 months ago

Owner: changed from team to hun.30d@…
Status: newneedinfo

If you can reproduce it and give us steps to reproduce, that would be very helpful.

Otherwise, we will just be shooting in the dark as to what the problem cause was, and that will take a lot of time.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as needinfo The owner will remain hun.30d@….
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hun.30d@… to the specified user. Next status will be 'new'.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from hun.30d@… to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.