Hitting Plus Twice in Turn Lanes Throws an Error

[anonymous]

What steps will reproduce the problem?

1. I clicked on an intersection opened up the turn lanes
2. Hit Plus and it added a lane
3. Hit Plus again and it threw an error.

What is the expected result?

Not sure, literally the first time I started using Turn Lanes and I was experimenting to see how it works. Maybe it was going to add another turn lane.

What happens instead?

Error

Please provide any additional information below. Attach a screenshot if possible.

Revision:18940
Build-Date:2024-01-17 12:43:02

Identification: JOSM/1.5 (18940 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19045)
Memory Usage: 588 MB / 8176 MB (332 MB allocated, but free)
Java version: 17.0.10+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 1600×900 (scaling 1.00×1.00) \Display2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18940, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ FixAddresses (36126)
+ SimplifyArea (36200)
+ continuosDownload (103)
+ fastdriveway (v1.0.1)
+ gridify (1606242219)
+ imagery_offset_db (36126)
+ splinex (36126)
+ turnlanes (36200)
+ turnrestrictions (36200)

Map paint styles:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/US.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/Direction&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/TreeCrownDiameter&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MappingAccessibility&zip=1

Last errors/warnings:
- 00000.280 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.281 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.699 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00065.346 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00065.448 E: Failed to locate image 'https://www.fs.usda.gov/sites/all/themes/fs_hq/images/usfslogo.png'
- 00147.600 E: Handled by bug report queue: java.lang.IllegalArgumentException: from > length



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (24) of main
java.lang.IllegalArgumentException: from > length
	at org.openstreetmap.josm.plugins.turnlanes.gui.Path$Line.subpath(Path.java:222)
	at org.openstreetmap.josm.plugins.turnlanes.gui.Path$Line.subpath(Path.java:228)
	at org.openstreetmap.josm.plugins.turnlanes.gui.Path$Line.subpath(Path.java:228)
	at org.openstreetmap.josm.plugins.turnlanes.gui.Path.subpath(Path.java:598)
	at org.openstreetmap.josm.plugins.turnlanes.gui.LaneGui.recalculate(LaneGui.java:337)
	at org.openstreetmap.josm.plugins.turnlanes.gui.RoadGui.paintLanes(RoadGui.java:736)
	at org.openstreetmap.josm.plugins.turnlanes.gui.RoadGui.paintLanes(RoadGui.java:677)
	at org.openstreetmap.josm.plugins.turnlanes.gui.RoadGui.paint(RoadGui.java:600)
	at org.openstreetmap.josm.plugins.turnlanes.gui.JunctionPane.paintPassive(JunctionPane.java:451)
	at org.openstreetmap.josm.plugins.turnlanes.gui.JunctionPane.paintComponent(JunctionPane.java:391)
	at java.desktop/javax.swing.JComponent.paint(Unknown Source)
	at java.desktop/javax.swing.JComponent.paintChildren(Unknown Source)
	at java.desktop/javax.swing.JComponent.paint(Unknown Source)
	at java.desktop/javax.swing.JComponent.paintToOffscreen(Unknown Source)
	at java.desktop/javax.swing.RepaintManager$PaintManager.paintDoubleBufferedImpl(Unknown Source)
	at java.desktop/javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
	at java.desktop/javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
	at java.desktop/javax.swing.RepaintManager.paint(Unknown Source)
	at java.desktop/javax.swing.JComponent._paintImmediately(Unknown Source)
	at java.desktop/javax.swing.JComponent.paintImmediately(Unknown Source)
	at java.desktop/javax.swing.RepaintManager$4.run(Unknown Source)
	at java.desktop/javax.swing.RepaintManager$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
	at java.desktop/javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
	at java.desktop/javax.swing.RepaintManager.prePaintDirtyRegions(Unknown Source)
	at java.desktop/javax.swing.RepaintManager$ProcessingRunnable.run(Unknown Source)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)

[GerdP]

I was not able to reproduce this problem. Please add a link to the crossing node.

[GerdP]

See also #23459, I fear version 36200 of this plugin is bogus.

[GerdP]

I wonder if this plugin ever worked and what exactly it is supposed to do. The way it tries to add commands to the undo/redo stack looks completely wrong or maybe it is just outagaged?
Looking at the top of the wiki page it seems a waste of time to fix this as it seems to support a proposal which was never approved.
@stoecker: Do we have a way to prohibit the load of such a plugin?

[stoecker]

Replying to GerdP:

I wonder if this plugin ever worked and what exactly it is supposed to do. The way it tries to add commands to the undo/redo stack looks completely wrong or maybe it is just outagaged?

Not outdated. If it's wrong, then it's simply wrong.

Looking at the top of the wiki page it seems a waste of time to fix this as it seems to support a proposal which was never approved.

There are turnlanes actively used. I have no idea whether this plugin is compatible with these or not.

@stoecker: Do we have a way to prohibit the load of such a plugin?

Yes. We can deprecate a plugin completely. trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java#L102​
Deprecating a bad plugin with this method would be a bit harsh...

[GerdP]

I meant this wiki: ​https://wiki.openstreetmap.org/wiki/Proposal:Turn_lanes_(relation)#Plugin

[GerdP]

@anonymous: Are you able to reproduce? If yes, please describe more detailed how. I assume this happened because of rounding issues with double values.