Address duplication and street name formatting Issue

[The Polish]

What steps will reproduce the problem?

1. Download the data (nodes or buildings) containing duplicate addresses, i.e., two identical building numbers on the same street in the same town.
2. Verify the data by pressing Shift + V.

What is the expected result?

1. If there are spaces in the street name, these spaces should also be displayed in the error window.

What happens instead?

1. In the error list window, the street name is incorrectly written: there is no space displayed between two parts of the street name.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18940
Build-Date:2024-01-17 12:43:02

Identification: JOSM/1.5 (18940 pl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 722 MB / 4068 MB (145 MB allocated, but free)
Java version: 17.0.10+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.25×1.25)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1250
System property sun.jnu.encoding: Cp1250
Locale info: pl_PL
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18940, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Program arguments: [%UserProfile%\Desktop\JOSM.jos]
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (36200)
+ todo (137)
+ utilsplugin2 (36200)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Potlatch2&zip=1

Validator rules:
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss

Last errors/warnings:
- 00000.478 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.480 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.030 E: java.security.KeyStoreException: Windows-ROOT not found. Przyczyna: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[The Polish]

wrong street name

[GerdP]

Yes, this is a bit confusing, on the other hand it shows why (how) JOSM "thinks" this is a problem.
The warning message shows a simplified address which is used in the calculation process. The address is simplified to be able to find duplicate numbers even when there a small spelling differences (Mozart-Gasse, Mozart Gasse, and Mozartgasse are all treated the same) Besides that name the value - or value list - in addr:housenumber and also addr:housename, addr:unit, and addr:flats are taken into account to build an address. A single OSM object can result in multiple "simplified addresses" if addr:housenumber contains a list (like "12,14,16" or "1;3"). We find a duplicate if there is an object Mozortgasse 5 and another with Mozartgasse 3,5.

That said we might add maybe 20 lines of code to detect the given very simple case where all addr:* tags are equal, but we would still report the simplified name in many other cases.
A contra argument would be that we would calculate the error with one value and show the error with a different value. This means we have to make sure that shown value is really a duplicate even if later an additional tag is used for the calculation of the simplified address.

Since the correct names are shown in the expanded list I think it's a good compromise.