PATCH][RFC] Add/ignore popular tags: cyclestreet=yes, footway=link, footway=traffic_island, fortification_type=ringfort, guidepost=hiking, industrial=wellsite, landuse=static_caravan, lane_markings=no, man_made=avalanche_protection, man_made=planter, parking:both=lane, parking:both=no, railway=miniature, service=driveway2

[taylor.smock]

https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/lastCompletedBuild/jdk=JDK8/testReport/org.openstreetmap.josm.data.osm/TaginfoTestIT/testCheckPopularTags__/

• cyclestreet=yes - 11003: Ignore (seems to be region specific)
• footway=link - 10571: Added (this patch)
• footway=traffic_island - 10206: Added (this patch)
• fortification_type=ringfort - 10144: Added (this patch)
• guidepost=hiking - 10355: Added (this patch, most other guidepost subkeys as well)
• highway=busway - 12808
• industrial=wellsite - 10279: Added (this patch)
• landuse=static_caravan - 12217: Ignore (this seems to be from an import)
• lane_markings=no - 582634: Added (this patch)
• man_made=avalanche_protection - 10654: Added (this patch)
• man_made=planter - 10449: Added (this patch)
• parking:both=lane - 10481: Added (this patch; most parking:*: actually)
• parking:both=no - 49081: Added (this patch)
• place=municipality - 10146
• railway=miniature - 10212: Added (this patch)
• service=driveway2 - 13112: Treating as a misspelling of driveway since that is what it will be for everyone except a single user
• trailblazed=symbols - 28212

No specific rendering support has been added yet.

I would specifically like comments on the icons.

[skyper]

Some comments:

• parking:[side][:*]=* is covered by the external preset Presets/ParkingLanes. I vote for ignoring parking:both=lane and parking:both=no
• cyclestreet=yes is the equivalent to bicycle_road=yes (included in JOSM for quite some time) and the former one is used in more countries than the latter one. Here we would need presets per country, again, but ignoring the former in favor of the latter is problematic.
• I do not like ​Key:guidepost. What is the difference to adding all transport modes like hiking=yes, bicycle=yes, mtb=yes, … which is the established way? I vote for ignoring guidepost=* for now.

[taylor.smock]

Replying to skyper:

Some comments:

• parking:[side][:*]=* is covered by the external preset Presets/ParkingLanes. I vote for ignoring parking:both=lane and parking:both=no

Fair point. Those were the two icons that took me the longest amount of time to make too. But none of the icons I made are "very good" anyway.

I guess we should probably look at defining when it would be a good idea to move presets from an external preset to the internal preset. Not 10k (since that is the minimum threshold), but maybe 100k uses?

• cyclestreet=yes is the equivalent to bicycle_road=yes (included in JOSM for quite some time) and the former one is used in more countries than the latter one. Here we would need presets per country, again, but ignoring the former in favor of the latter is problematic.

Probably making the two exclusionary will work. I think I saw something that would allow that in the preset xsd.

• I do not like ​Key:guidepost. What is the difference to adding all transport modes like hiking=yes, bicycle=yes, mtb=yes, … which is the established way? I vote for ignoring guidepost=* for now.

I'll note that the root object (​osmwiki:Tag:tourism=information and ​osmwiki:Tag:information=guidepost) is signage, not routing. So guidepost=<mode> is just indicating who the guide post is for, not who can access it. So

tourism=information
        information=guidepost
                    guidepost=<mode>

With that said, I don't care if we ignore it, but it is a relatively small diff either way (literally one line, since it is a subtag for a pre-existing preset).

[skyper]

Replying to taylor.smock:

Replying to skyper:

Some comments:

• parking:[side][:*]=* is covered by the external preset Presets/ParkingLanes. I vote for ignoring parking:both=lane and parking:both=no

Fair point. Those were the two icons that took me the longest amount of time to make too. But none of the icons I made are "very good" anyway.

I am sorry, that I did not create this ticket by myself earlier.

I guess we should probably look at defining when it would be a good idea to move presets from an external preset to the internal preset. Not 10k (since that is the minimum threshold), but maybe 100k uses?

+1,
does this count for :lanes tag, too, and how to handle the additional mappaint styles?

• cyclestreet=yes is the equivalent to bicycle_road=yes (included in JOSM for quite some time) and the former one is used in more countries than the latter one. Here we would need presets per country, again, but ignoring the former in favor of the latter is problematic.

Probably making the two exclusionary will work. I think I saw something that would allow that in the preset xsd.

Wow, this would be a much needed feature.

• I do not like ​Key:guidepost. What is the difference to adding all transport modes like hiking=yes, bicycle=yes, mtb=yes, … which is the established way? I vote for ignoring guidepost=* for now.

I'll note that the root object (​osmwiki:Tag:tourism=information and ​osmwiki:Tag:information=guidepost) is signage, not routing. So guidepost=<mode> is just indicating who the guide post is for, not who can access it. So

tourism=information
        information=guidepost
                    guidepost=<mode>

With that said, I don't care if we ignore it, but it is a relatively small diff either way (literally one line, since it is a subtag for a pre-existing preset).

No, these are no access tags in this case but tags to state which kind of routes are signed. I did not take a closer look at the history of guidepost=* but I fear this is just a different tagging approach which, by the way, would need to be a multiselect instead of a combo.

[taylor.smock]

Replying to skyper:

I am sorry, that I did not create this ticket by myself earlier.

No worries. I've been working this on and off for a month or so. It hasn't been high priority for me, but I would like to reduce the number of test failures from the build system.

I guess we should probably look at defining when it would be a good idea to move presets from an external preset to the internal preset. Not 10k (since that is the minimum threshold), but maybe 100k uses?

+1 [minimum threshold for moving external preset to internal preset],
does this count for :lanes tag, too, and how to handle the additional mappaint styles?

Probably "yes". But there should definitely be a discussion with other maintainers on this.

Probably making the two exclusionary will work. I think I saw something that would allow that in the preset xsd.

Wow, this would be a much needed feature.

Nevermind. It looks like (a) bicycle_street is a distinct preset and (b) the feature I was thinking of doesn't do what I think it did.
With that said, one of the possible GSOC ​projects includes adding some of the Vespucci preset ​extensions to JOSM. If that project gets selected, I should probably talk with SimonPoole about designing what an exclusionary tag would look like.

With that said, I don't care if we ignore it, but it is a relatively small diff either way (literally one line, since it is a subtag for a pre-existing preset).

No, these are no access tags in this case but tags to state which kind of routes are signed. I did not take a closer look at the history of guidepost=* but I fear this is just a different tagging approach which, by the way, would need to be a multiselect instead of a combo.

Multiselect might be better. I don't know (I don't map them). It might be better to leave them off for now, especially since it looks like hiking= is the predominant tag for recording the type of guidepost.

[taylor.smock]

Drop parking, don't ignore cyclestreet (not added as a preset yet), ignore guidepost

[taylor.smock]

Ticket #22932 has been marked as a duplicate of this ticket.

[taylor.smock]

Add footway=alley

[Tjuro]

Does adding a value to a preset list prevent the "footway=* has to be X" warning for that value? or are the validator and the presets seperate lists?

[taylor.smock]

Replying to Tjuro:

Does adding a value to a preset list prevent the "footway=* has to be X" warning for that value? or are the validator and the presets seperate lists?

This was fixed in #21235/r18523, if I understand the question correctly.

The validator will check to make certain that tags are in presets and/or in the ignore file.

[taylor.smock]

In 18730/josm:

Fix #22901: Add/ignore popular tags

Ignore:

• landuse=static_caravan (mostly from an import)
• service=driveway2 (largely driven by a single user, for everyone else it is a misspelling of driveway)
• guidepost (maybe a duplicate with hiking=yes/bicycle=yes since it is a list, e.g. guidepost=hiking;bicycle
• Street side parking tags (parking:<side>:*; there is an external preset for these)

Add:

• lane_markings
• footway=link|traffic_island|alley
• railway=miniature
• man_made=avalanche_protection
• fortification_type (for historic=archaeological_site)
• man_made=planter
• industrial=wellsite