[patch] Link to context sensitive help is missing for "Expert Mode"

[skyper]

What steps will reproduce the problem?

1. Hover mouse over View menu item "Expert Mode"
2. Press F1

What is the expected result?

wiki:Help/ExpertMode

What happens instead?

Help content for the help topic Action/ExpertToggle is not available yet.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-02 08:22:33 +0100 (Thu, 02 Mar 2023)
Revision:18679
Build-Date:2023-03-03 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

[gaben]

src/org/openstreetmap/josm/actions/ExpertToggleAction.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.actions;
 
+import static org.openstreetmap.josm.gui.help.HelpUtil.ht;
 import static org.openstreetmap.josm.tools.I18n.tr;
 
 import java.awt.Component;
@@ -113 +114 @@
                 new ImageProvider("expert").setOptional(true),
               tr("Enable/disable expert mode"),
               null,
-              false /* register toolbar */, null, false
+              false /* register toolbar */, "expertmode", false
         );
-        setToolbarId("expertmode");
+        setHelpId(ht("/ExpertMode"));
         if (MainApplication.getToolbar() != null) {
             MainApplication.getToolbar().register(this);
         }

Edit: also moved the toolbarId setup to the constructor. One less line of code.

[Klumbumbus]

In 18682/josm:

fix #22784, fix #22785, fix #22786 - Add context sensitive help links, patches by gaben