[patch] Link to context sensitive help is missing for "Search for objects by preset"

[skyper]

What steps will reproduce the problem?

1. Hover mouse over Presets menu item "Search for objects by preset"
2. Press F1

What is the expected result?

wiki:Help/Action/TaggingPresetSearchPrimitive

What happens instead?

Help content for the help topic Action/TaggingPresetSearchPrimitiveDialog$ is not available yet.

Please provide any additional information below. Attach a screenshot if possible.

Note that the action is also available in the Edit menu with the identical result.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-02 08:22:33 +0100 (Thu, 02 Mar 2023)
Revision:18679
Build-Date:2023-03-03 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

[gaben]

src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSearchPrimitiveDialog.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui.tagging.presets;
 
+import static org.openstreetmap.josm.gui.help.HelpUtil.ht;
 import static org.openstreetmap.josm.tools.I18n.tr;
 
 import java.awt.event.ActionEvent;
@@ -34 +35 @@
         public Action() {
             super(tr("Search for objects by preset..."), "dialogs/search", tr("Search for objects by their presets."),
                     Shortcut.registerShortcut("preset:search-objects", tr("Presets: {0}", tr("Search for objects by preset...")),
-                    KeyEvent.VK_F3, Shortcut.SHIFT), false);
-            putValue("toolbar", "presets/search-objects");
-            MainApplication.getToolbar().register(this);
+                    KeyEvent.VK_F3, Shortcut.SHIFT), true, "presets/search-objects", true);
+            setHelpId(ht("/Action/TaggingPresetSearchPrimitive"));
         }
 
         @Override

I also moved the toolbar registration and toolbarId setup to the constructor call. I don't know why are there such setups in a few places like here.

[Klumbumbus]

In 18682/josm:

fix #22784, fix #22785, fix #22786 - Add context sensitive help links, patches by gaben