Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#22787 closed defect (fixed)

Do not check if value of `addr:housenumber` key exists in presets

Reported by: marc_marc Owned by: team
Priority: normal Milestone: 23.03
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. tag an object with addr:housenumber=1
  2. run the validaator

What is the expected result?

nothing about addr:housenumber

What happens instead?

"le modèle d'attributs ne contient pas de valeur - La valeur "1" est absence du modèle d'attributs pour la clé "addr:housenumber""
translated to something like The attribute template does not contain a value - The value "1" is missing from the attribute model for the key "addr:housenumber"

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-01 15:17:42 +0100 (Wed, 01 Mar 2023)
Build-Date:2023-03-02 02:30:57
Revision:18678
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18678 fr) Linux CentOS Linux release 7.9.2009 (Core)
Memory Usage: 454 MB / 1717 MB (247 MB allocated, but free)
Java version: 1.8.0_362-b08, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: fr_CH.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: fr
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME-Classic:GNOME
Java package: java-1.8.0-openjdk:x86_64-1.8.0.362.b08
WebStart package: icedtea-web:x86_64-1.7.1
VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
Dataset consistency test: No problems found

Plugins:
+ ImproveOsm (235)
+ Mapillary (2.1.1)
+ apache-commons (36034)
+ apache-http (35924)
+ areaselector
+ austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e)
+ cadastre-fr (36021)
+ conflation (0.6.9)
+ continuosDownload (105)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36034)
+ opendata (36025)
+ pt_assistant (1ff2e15)
+ reverter (36043)
+ scripting
+ todo (123)
+ utilsplugin2 (36011)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/BENELUX&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/MountainbikeTrails&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/geoimage.at&zip=1
+ https://github.com/Jungle-Bus/josm-presets/raw/gh-pages/jungle-stops/Preset_Jungle-Bus.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/MobilePhoneBaseStations&zip=1
+ https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://raw.github<user.name>content.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/WifiHotspots&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Wikidata&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1
+ https://raw.github<user.name>content.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/Pictures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://raw.github<user.name>content.com/osmlu/josm-validator-luxembourg/master/Luxembourg-Specific-Rules.validator.mapcss
+ https://raw.github<user.name>content.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss

Last errors/warnings:
- 00035.222 W: Le greffon scripting nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00035.224 W: Le greffon areaselector nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00052.064 E: Impossible de trouver l'image "bus.png"

Attachments (0)

Change History (5)

comment:1 by Klumbumbus, 2 years ago

Milestone: 23.03

Analogue to #22761 it happens only with an external preset with a combo for addr:housenumber (which doesn't make much sense)

comment:2 by Klumbumbus, 2 years ago

Resolution: fixed
Status: newclosed

In 18680/josm:

fix #22787 - Don't warn about "Value '<some value>' for key 'addr:housenumber' not in presets"

comment:3 by skyper, 2 years ago

Is it really useful to ignore the key instead of fixing the external preset?

comment:4 by Klumbumbus, 2 years ago

Ignoring doesn't hurt. One need to find out from which preset in the status report the warning comes to double check if it makes sense or not.

comment:5 by skyper, 2 years ago

First of all it is an informational warning and a valid one as the presets do not contain the value.
People can create and use external presets in every way they like to. Do we really want to ignore all keys which have an incomplete list of values in any external preset? Next candidates would be addr:street, addr:city, addr:place, …

How about excluding external presets from this test in general or even better implement a new preset attribute to exclude the key's values from the test?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.