ignore list doesn't work

[GerdP]

What steps will reproduce the problem?

1. Validate attached file with information level activated and the following settings

validator.UnconnectedWays.node_way_distance_railway 1
validator.UnconnectedWays.way_way_distance 1.0

2. You should find information message

Connected way end node near other way (1)TestError [tester=org.openstreetmap.josm.data.validation.tests.UnconnectedWays$UnconnectedHighways@178cb746, unique code=-1765317246, code=1311, message=Connected way end node near other way]

3. select this message and click on ignore
4. run validator again

What is the expected result?

the info message is not shown again

What happens instead?

the info message appears again

Please provide any additional information below. Attach a screenshot if possible.

I find this entry in preferences.xml:
<tag key=':n_1129771211:w_342134203' value='-1765317246_1311'/>

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-01-29 21:53:34 +0100 (Sun, 29 Jan 2023)
Revision:18646
Build-Date:2023-01-30 02:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18646 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 280 MB / 1972 MB (154 MB allocated, but free)
Java version: 17.0.4+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18531, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35924)
+ RoadSigns (36038)
+ apache-commons (36034)
+ buildings_tools (36011)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ o5m (35893)
+ opendata (36025)
+ pbf (36034)
+ poly (35976)
+ reltoolbox (35976)
+ reverter (36043)
+ undelete (36011)
+ utilsplugin2 (36011)

Validator rules:
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- 00000.578 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.580 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.992 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[GerdP]

Maybe a regression from r18636?

[taylor.smock]

I wrote tests specifically to avoid this, and when I was manually testing, it was working.

I'll see if I can track it down.

[GerdP]

One more info:
The entry in preferences.xml changed to <tag key=':n_1129771211:w_342134203' value=''/>
Maybe the negative hash value causes problems while parsing?

[taylor.smock]

That might be it -- I just ignored the top two from my test area, and it worked. Neither one had a - in the hashcode.

[taylor.smock]

I've been able to reproduce -- it looks like the OsmValidator#save call modifies the list. I've adapted the test for this, and I'm looking into fixing the problem. It appears to be a simple regex update, but I'm waiting on the full test suite to finish.

[taylor.smock]

In 18649/josm:

Fix #22712: ignore list doesn't work

This occurred due to OsmValidator#save modifying the list, and expecting
all error codes to be positive.

TestErrorTest now checks one of the tests known to have a negative hashcode.

This also adds some additional JUnit 5 annotations. The additional
annotations are:

• @LayerManager (cleans up layers after each test run)
  • This is automatically registered for all tests
• @Projection (sets up the ProjectionRegistry for each test)

[taylor.smock]

Well, it looks like we have a total of 18 tests which have a negative hashcode.

• org.openstreetmap.josm.data.validation.OsmValidatorTest$1 -- not a problem as it is an anonymous class for testing
• org.openstreetmap.josm.data.validation.tests.Addresses
• org.openstreetmap.josm.data.validation.tests.ApiCapabilitiesTest
• org.openstreetmap.josm.data.validation.tests.BarriersEntrances
• org.openstreetmap.josm.data.validation.tests.ConditionalKeys
• org.openstreetmap.josm.data.validation.tests.CrossingWays$Boundaries
• org.openstreetmap.josm.data.validation.tests.CrossingWays$SelfCrossing
• org.openstreetmap.josm.data.validation.tests.CrossingWays$Ways
• org.openstreetmap.josm.data.validation.tests.DirectionNodes
• org.openstreetmap.josm.data.validation.tests.DuplicateNode
• org.openstreetmap.josm.data.validation.tests.Lanes
• org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker$MapCSSTagCheckerAndRule -- probably not an issue, since we have effectively hardcoded the mapcss errors to be 3000
• org.openstreetmap.josm.data.validation.tests.PowerLines
• org.openstreetmap.josm.data.validation.tests.TagChecker
• org.openstreetmap.josm.data.validation.tests.TagCheckerTest$1 -- not a problem as it is an anonymous class for testing
• org.openstreetmap.josm.data.validation.tests.UnconnectedWays$UnconnectedHighways
• org.openstreetmap.josm.data.validation.tests.UntaggedWay
• org.openstreetmap.josm.data.validation.tests.WayConnectedToArea

[skyper]

Ticket #22754 has been marked as a duplicate of this ticket.