Opened 5 months ago
Last modified 3 months ago
#22308 needinfo enhancement
[Patch] Add option to toggle layer read-only status to popup menu
Reported by: | Woazboat | Owned by: | Woazboat |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | |
Keywords: | layer, state, read-only, toggle, lock, locked | Cc: | MSiipola |
Description (last modified by )
Add a new menu item to the layer popup context menu that allows toggling of the read-only lock state for data layers
https://github.com/JOSM/josm/pull/99
https://patch-diff.githubusercontent.com/raw/JOSM/josm/pull/99.patch
Attachments (1)
Change History (7)
Changed 5 months ago by
Attachment: | josm_layer_read_only_toggle.gif added |
---|
comment:1 Changed 5 months ago by
Description: | modified (diff) |
---|
comment:2 Changed 5 months ago by
comment:3 Changed 3 months ago by
Owner: | changed from team to Woazboat |
---|---|
Status: | new → needinfo |
@Woazboat: do you have any response for skyper's comment?
I'm going to hold off on merging this patch for now.
We'd probably have to have a secondary field (lockedOnLoad
or something) to indicate that the provider of the data does not want the data to be accidentally uploaded. Either that, or if the dataset is locked on load, it cannot be unlocked via this popup menu option.
comment:5 Changed 3 months ago by
I would not ease the changing of locked
and upload
as they are usually set for good reason.
How about two more states, gui_locked
and gui_upload
, identical to locked
and upload
but changeable from the GUI.
comment:6 Changed 3 months ago by
Cc: | MSiipola added |
---|---|
Keywords: | state added |
-1
Modification is blocked by reason and I think this would make it to easy to change from
locked
status. An option to changing the status fordownload=*
might be an improvement but not forlocked
orupload
.