[Patch] Add popup menu for notes

[Woazboat]

Add a popup menu with possible actions when right-clicking on a note in the notes list

​https://github.com/JOSM/josm/pull/98
​https://patch-diff.githubusercontent.com/raw/JOSM/josm/pull/98.patch

[Woazboat]

Demonstration of the notes popup menu

[taylor.smock]

Stupid question:
Why is notesPopupMenu a field? It seems like it should be a local variable, since it appears to not be used anywhere else.

[Woazboat]

That's how I had it at first until I moved it to a field (in preparation for any future expansion that makes use of the popup menu such as plugin hooks, etc...). That should probably be done by any future patches that actually implement that though, so you're right. I'll change it back to a local variable.

[taylor.smock]

OK. Works for me. I'll try to get my working directory cleaned up so I can actually (a) apply your patch and (b) make certain that nothing broke (having looked at the patch, highly unlikely).

[taylor.smock]

In 18540/josm:

Fix #22307: Add popup menu for notes (patch by Woazboat)

The popup menu has the following actions:

• Comment
• Open in Browser
• Close
• Reopen

[Kmpopppe]

Nice one, @Woazboat ... I'd love to use that for the NoteSolver Plugin to add my "Remember" and "Forget" entries ... Is there any way to access that context menu?

[taylor.smock]

Not currently. We could probably add two methods for adding/removing options fairly easily.
Since I'm on vacation right now, it will be a few weeks before I can do anything.

[Kmpopppe]

I have been fighting with the Context Menu of that plugin and it overlaying the core note popup for over a year while also furiously right-clicking the notes in the notes window and wondering why nothing happened (before your change of course) as long as I've been using JOSM, so ... take any time you like :-D

If you want me to test that methods in a pre-release state and if they work with my plugin by all means, just drop me a line, it's the same username for the Wiki and OSM (lowercase k) :-)

Thank you!

[taylor.smock]

@Kmpopppe: Can you create a new ticket for extending the popup menu?

I'd specifically like to know what you expect to happen when you add to the menu, and how you think you will be using it (just so I don't do something that isn't what you expected).