Mapillary plugin: NullPointerException MapillaryLayer.lambda$updateSequence$15

[richlv]

What steps will reproduce the problem?

1. Clicking around the map view with geotagged and Mapillary images

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-08-01 20:38:58 +0200 (Mon, 01 Aug 2022)
Build-Date:2022-08-02 01:30:56
Revision:18531
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18531 en_GB) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H2026)
Memory Usage: 2579 MB / 3641 MB (1249 MB allocated, but free)
Java version: 1.8.0_341-b10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69733382 1680×1050 (scaling 1.00×1.00)
Maximum Screen Size: 1680×1050
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlp.tk=awt, -Djnlpx.jvm=<java.home>/bin/java, -Djnlpx.splashport=-1, -Djnlpx.home=<java.home>/bin, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true, -Djnlpx.session.data=/var/folders/nl/flqxqsmj5q963r7tcnfrdt3c0000gn/T/session1515246839397609760, -Djnlpx.heapsize=NULL,NULL, -Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.origFilenameArg=/Users/richlv/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-72e8e992, -Dsun.awt.warmup=true, -Djava.security.manager]
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (35951)
+ InfoMode (35978)
+ Mapillary (2.0.0-beta.15)
+ PicLayer (1.0.2)
+ apache-commons (36003)
+ apache-http (35924)
+ buildings_tools (36011)
+ dataimport (35932)
+ ejml (35924)
+ geotools (36008)
+ imagery_offset_db (35978)
+ jackson (36006)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ measurement (35978)
+ opendata (36011)
+ pbf (35978)
+ photo_geotagging (35933)
+ reverter (36011)
+ utilsplugin2 (36011)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 14433.829 E: Failed to locate image '[[Image(pond.png)]]'
- 14434.251 E: Failed to locate image '[[Image(oil-palm.png)]]'
- 15626.272 E: Handled by bug report queue: java.lang.NullPointerException
- 15628.100 E: Handled by bug report queue: java.lang.NullPointerException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (31) of javawsApplicationThreadGroup
java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.MapillaryLayer.lambda$updateSequence$15(MapillaryLayer.java:762)
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
	at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:479)
	at java.util.stream.ReferencePipeline.max(ReferencePipeline.java:515)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.MapillaryLayer.lambda$updateSequence$18(MapillaryLayer.java:763)
	at java.util.Optional.orElseGet(Optional.java:267)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.MapillaryLayer.updateSequence(MapillaryLayer.java:762)
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.process(MapillarySequenceDownloader.java:181)
	at javax.swing.SwingWorker$3.run(SwingWorker.java:414)
	at sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
	at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
	at sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
	at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
	at javax.swing.Timer.fireActionPerformed(Timer.java:313)
	at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[taylor.smock]

+ Mapillary (2.0.0-beta.15)

I believe this was fixed in ​3c223cb724b57a48913d709506c47a3716a76bdf.

Anyway, I was able to reproduce on beta.15 but not beta.17.

java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.MapillaryLayer.lambda$updateSequence$15(MapillaryLayer.java:762)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:558)
	at java.base/java.util.stream.ReferencePipeline.max(ReferencePipeline.java:594)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.MapillaryLayer.lambda$updateSequence$18(MapillaryLayer.java:763)
	at java.base/java.util.Optional.orElseGet(Optional.java:369)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.MapillaryLayer.updateSequence(MapillaryLayer.java:762)
	at org.openstreetmap.josm.plugins.mapillary.gui.workers.MapillarySequenceDownloader.process(MapillarySequenceDownloader.java:181)
	at java.desktop/javax.swing.SwingWorker$3.run(SwingWorker.java:423)

Anyway, steps to reproduce:

1. Select sequence
2. Before sequence finishes loading, deselect the sequence.

[richlv]

Thank you for looking into this, appreciated :)

[taylor.smock]

No problem. I'm trying to close all crashing bugs as soon as possible (and I'm trying to decrease the overall number of open tickets).