Modify

Opened 5 months ago

Last modified 5 months ago

#21964 assigned enhancement

Include leisure=sports_hall

Reported by: skyper Owned by: skyper
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: leisure sports_hall Cc: Hufkratzer

Description

In #21396 leisure=sports_hall is mentioned reaching our limit.
@Hufkratzer already proposed an icon Proposal 1 for sports_hall icon which is ok but I rather have an icon for sport=multi included than only a soccer ball.

Note: The new value needs to be added to many sports presets which have leisure=* included, e.g. see #21907.

Attachments (3)

sports_hall.svg (6.7 KB) - added by skyper 5 months ago.
sports_hall icon including multi sports
white_sports_hall.svg (7.8 KB) - added by Hufkratzer 5 months ago.
gray_sports_hall_without_background.svg (8.4 KB) - added by Hufkratzer 5 months ago.
gray sports hall without background (plain svg)

Download all attachments as: .zip

Change History (11)

Changed 5 months ago by skyper

Attachment: sports_hall.svg added

sports_hall icon including multi sports

comment:1 Changed 5 months ago by skyper

I came up with an enhanced icon:

sports_hall icon including multi sports (16px), sports_hall icon including multi sports (64px)

comment:2 Changed 5 months ago by Hufkratzer

I tried something similar. You were faster.

In the 16px version, I can't see much. I made a modified version of it with a white painted sports hall. I think that may help. I will attach it here.

Changed 5 months ago by Hufkratzer

Attachment: white_sports_hall.svg added

comment:3 Changed 5 months ago by Hufkratzer

BTW some question: Where is the 64px version used in JOSM?

comment:4 Changed 5 months ago by skyper

Yes, white makes sense. Maybe we should get rid of the green background, too, and scale it up a little bit to use the width of 16px for the building.

Anyway, I will start working on the preset and probably merge it with #21907.

Regarding the 64px version, this is no file on its own but simply the 16px scaled with the [[Image()]] macro of trac for a better view.
I am not sure if we have 64px icons per default, maybe on UHD with general 2x scale. Anyway there are options for bigger icons in mappaint and e.g. the top panel.

comment:5 Changed 5 months ago by Hufkratzer

gray_sports_hall_without_background.svg:

gray sports hall without background (plain svg) (16px), gray sports hall without background (plain svg) (64px)

The ingredients are still hard to recognize in the 16px view.

comment:6 Changed 5 months ago by skyper

Thanks.
Well, it is the same with sport=multi source:trunk/resources/images/presets/sport/multi.svg and leisure=sports_centre source:trunk/resources/images/presets/sport/sports_centre.svg. I guess, we all will have to suffer some kind of death. I won't spend too much time on icons, though, there is much room for improvements regarding the existing ones and it is usually the major work for new presets. E.g. Adding icons to the multiselect, I just noticed that we miss some sport=* icons and the existing ones are often far from being perfect.

comment:7 in reply to:  5 Changed 5 months ago by skyper

Replying to Hufkratzer:

gray_sports_hall_without_background.svg:

By the way, we only need plain svg files for JOSM.

Changed 5 months ago by Hufkratzer

gray sports hall without background (plain svg)

comment:8 Changed 5 months ago by skyper

I slightly fixed and updated the icon.
Changes are included in #21907.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain skyper.
as The resolution will be set.
to The owner will be changed from skyper to the specified user.
The owner will change to skyper
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.