Modify

Opened 2 years ago

Last modified 7 months ago

#21917 new defect

'except' tag in the turnrestrictions plugin

Reported by: angoca Owned by: team
Priority: normal Milestone:
Component: Plugin turnrestrictions Version: latest
Keywords: template_report except tag undocumented Cc:

Description

What steps will reproduce the problem?

  1. When using the turnrestrictions plugin and selecting the exceptions for a given restriction, this plugin is introducing an undocumented key.
  2. By checking the wiki documentation, I didn't find anything at https://wiki.openstreetmap.org/w/index.php?title=Key:except. This page redirects to Relation:restriction which is a general thing. Also, there are no Wiki pages for any tag combination with this key (i.e. except=bicycle). In other words, the plugin is using a non accepted key.
  3. When looking at the talk page of Relation:retriction, this key has a lot of discussions and it seems it could create many issues.

In conclusion, this plugin should not introduce something that could create errors, or generate controversies.

What is the expected result?

Use another accepted tag, or do not provide this option until fully approved.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022)
Build-Date:2022-01-02 20:26:19
Revision:18360
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18360 en) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H1713)
Memory Usage: 1177 MB / 3641 MB (548 MB allocated, but free)
Java version: 1.8.0_321-b07, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69731270 1440×900 (scaling 1.00×1.00)
Maximum Screen Size: 1440×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_CO
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-16e9d1de, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-7a1c6b48.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35893)
+ Mapillary (2.0.0-beta.2)
+ PicLayer (1.0.1)
+ apache-commons (35893)
+ apache-http (35893)
+ buildings_tools (35908)
+ continuosDownload (99)
+ ejml (35893)
+ geotools
+ imagery-xml-bounds (35893)
+ imagery_offset_db (35893)
+ jna (35893)
+ jts (35893)
+ log4j (35893)
+ photo_geotagging (35893)
+ tageditor (35893)
+ terracer (35893)
+ turnlanes-tagging (v0.0.5)
+ turnrestrictions (35893)
+ utilsplugin2 (35893)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/SITP-Transmilenio&zip=1

Validator rules:
+ https://raw.githubusercontent.com/MaptimeBogota/ColombianJosmValidator/main/Rules_Colombian-specific.validator.mapcss

Last errors/warnings:
- 50603.672 W: Crossing ways test skipped WaySegment [way=1024405705, lowerIndex=3]
- 50603.673 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=0]
- 50603.673 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=1]
- 50603.674 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=2]
- 50603.674 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=3]
- 50603.675 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=4]
- 50603.675 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=5]
- 50603.675 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=6]
- 50603.676 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=7]
- 50603.676 W: Crossing ways test skipped WaySegment [way=166080818, lowerIndex=8]

Attachments (0)

Change History (5)

comment:1 by angoca, 2 years ago

The except key is not used a lot:

And Key:except redirect to restriction page, which means this is not correctly documented.

Also, an overpass turbo query does not show a lot of usage: https://overpass-turbo.eu/s/1gIl

Last edited 2 years ago by angoca (previous) (diff)

comment:2 by skyper, 2 years ago

I doubt that a wiki page for each value is useful and I already find many conflicts in the wiki because of these value pages. The key except exists since years and iD plus Vespucci support it.

The patch for #20833 would introduce it to JOSM core.

comment:5 by aceman444, 7 months ago

The values of 'except' key are documented on the main 'restriction' key page. I don't think there a strict rule that each tag or key must have its own wiki page.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to angoca.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.