F1 on Proxy Preferences does not arrive on the right page

[leni]

What steps will reproduce the problem?

1. on Proxy Preferences, I use F1

What is the expected result?

get to the page Help/Preferences/ProxyPreference

What happens instead?

arrive Help/Preferences/Connection

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-03-06 10:38:55 +0100 (Sun, 06 Mar 2022)
Build-Date:2022-03-07 02:31:09
Revision:18387
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18387 fr) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 505 MB / 910 MB (175 MB allocated, but free)
Java version: 1.8.0_311-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: fr_FR
Numbers with default locale: 1234567890 -> 1234567890

Plugins:
+ Mapillary (2.0.0-beta.4)
+ PicLayer (1.0.2)
+ apache-commons (35893)
+ apache-http (35893)
+ conflation (0.6.9)
+ contourmerge (v0.1.8)
+ ejml (35893)
+ flatlaf (35862)
+ geotools (35906)
+ imagery_offset_db (35893)
+ indoorhelper (1.2.0)
+ jaxb (35893)
+ jna (35893)
+ jts (35893)
+ measurement (35893)
+ openqa (0.2.2)
+ photo_geotagging (35893)
+ photoadjust (35893)
+ scripting (30798)
+ shrinkwrap (v1.0.4)
+ tageditor (35893)
+ todo (30306)
+ turnrestrictions (35893)
+ undelete (35893)
+ utilsplugin2 (35893)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
+ <josm.pref>\styles\sit.mapcss
+ <josm.pref>\styles\sit.mapcss
- <josm.pref>\styles\sit.mapcss
- <josm.pref>\styles\sit.mapcss

[skyper]

The proper HelpContext needs to be set in source.

[skyper]

Strange, #20652 e.g. r17648 should have set the correct page but only the help button leads to the proper page.

[taylor.smock]

The actual page is wiki:Help/Preferences/Connection#ProxySettings . See source:/trunk/src/org/openstreetmap/josm/gui/preferences/server/ProxyPreferencesPanel.java@HEAD:301#L301​ . I'll apply a patch for this in a few minutes.

[taylor.smock]

In 18389/josm:

fix #21918: Proxy preferences does not have the correct help

Remove the HelpUtil.setHelpContext in ProxyPreferencesPanel, as this overrides
the help context set in ProxyPreference#getHelpContext (see #20652). As the
correct help topic is the same as that set in ProxyPreference, we just remove
the setHelpContext call in ProxyPreferencesPanel.