Modify

Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#21738 closed enhancement (fixed)

[Patch] add tag definition for members of type=building relations and update the valdator warning

Reported by: skyper Owned by: team
Priority: normal Milestone: 22.02
Component: Internal preset Version:
Keywords: template_report building relation role type Cc:

Description (last modified by skyper)

This is a follow-up of #21285, see my comment 8

Currently, there is no tag definition for members of type=building relations. r18199 added a warning about missing building=* for the relation, but the wiki requests to have building=* on the member with role outline. E.g.

  • the preset should have some required tags for the members
    • at least for the relations, naming could be prettified with name_template
  • a warning for different values of building=* on the relation and its outline member is useful
  • the warning for missing building=* should be removed or downgraded to informal
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022)
Revision:18360
Build-Date:2022-01-02 20:26:19
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (1)

josm_21738.patch (3.2 KB) - added by skyper 3 months ago.
patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 months ago by skyper

Description: modified (diff)

Changed 3 months ago by skyper

Attachment: josm_21738.patch added

patch

comment:2 Changed 3 months ago by skyper

Milestone: 22.02
Owner: changed from skyper to team
Status: assignednew
Summary: add tag definnition for members of type=building relations and update the valdator warning[Patch] add tag definnition for members of type=building relations and update the valdator warning

Please, find attached patch, adding member_expressions=* and count=* to the building relation preset and a warning about conflicting values of building=* on the relation and the outline member.

There is already an informal warning about type=building together with building=* as building=* is not in the relation's preset.
I failed, so far, regarding name_template but that can be added later on.

Milestone 22.02 as the new warning needs to be translated.

comment:3 Changed 3 months ago by stoecker

Milestone: 22.0222.03

Milestone renamed

comment:4 Changed 3 months ago by stoecker

Milestone: 22.0322.02

Join milestones

comment:5 Changed 3 months ago by stoecker

Resolution: fixed
Status: newclosed

In 18369/josm:

fix #21738, patch by skyper, add tag definition for members of type=building relations and update the valdator warning

comment:6 Changed 3 months ago by skyper

Summary: [Patch] add tag definnition for members of type=building relations and update the valdator warning[Patch] add tag definition for members of type=building relations and update the valdator warning

comment:7 Changed 3 months ago by taylor.smock

Heads up, this broke a test (https://josm.openstreetmap.de/jenkins/job/JOSM/7670/).

I'm in the process of fixing it right now.

comment:8 Changed 3 months ago by taylor.smock

In 18374/josm:

RelationCheckerTest: Update tests for r18369

see #21738: update building relation preset, where non-closedways were removed
from the preset.

comment:9 Changed 3 months ago by skyper

Thanks.

Mean-while, I am not sure if the rule should use a parent selector instead of a child selector as it would select both, the outline way and the relation. Mapcss does not have an expression for role but JOSM search could be used, I guess.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.