#21738 closed enhancement (fixed)
[Patch] add tag definition for members of type=building relations and update the valdator warning
| Reported by: | skyper | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 22.02 |
| Component: | Internal preset | Version: | |
| Keywords: | template_report building relation role type | Cc: |
Description (last modified by )
This is a follow-up of #21285, see my comment 8
Currently, there is no tag definition for members of type=building relations. r18199 added a warning about missing building=* for the relation, but the wiki requests to have building=* on the member with role outline. E.g.
- the preset should have some required tags for the members
- at least for the relations, naming could be prettified with
name_template
- at least for the relations, naming could be prettified with
- a warning for different values of
building=*on the relation and itsoutlinemember is useful - the warning for missing
building=*should be removed or downgraded to informal
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022) Revision:18360 Build-Date:2022-01-02 20:26:19 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (1)
Change History (10)
comment:1 Changed 2 years ago by
| Description: | modified (diff) |
|---|
Changed 22 months ago by
| Attachment: | josm_21738.patch added |
|---|
comment:2 Changed 22 months ago by
| Milestone: | → 22.02 |
|---|---|
| Owner: | changed from skyper to team |
| Status: | assigned → new |
| Summary: | add tag definnition for members of type=building relations and update the valdator warning → [Patch] add tag definnition for members of type=building relations and update the valdator warning |
Please, find attached patch, adding member_expressions=* and count=* to the building relation preset and a warning about conflicting values of building=* on the relation and the outline member.
There is already an informal warning about type=building together with building=* as building=* is not in the relation's preset.
I failed, so far, regarding name_template but that can be added later on.
Milestone 22.02 as the new warning needs to be translated.
comment:6 Changed 22 months ago by
| Summary: | [Patch] add tag definnition for members of type=building relations and update the valdator warning → [Patch] add tag definition for members of type=building relations and update the valdator warning |
|---|
comment:7 Changed 22 months ago by
Heads up, this broke a test (https://josm.openstreetmap.de/jenkins/job/JOSM/7670/).
I'm in the process of fixing it right now.
comment:9 Changed 22 months ago by
Thanks.
Mean-while, I am not sure if the rule should use a parent selector instead of a child selector as it would select both, the outline way and the relation. Mapcss does not have an expression for role but JOSM search could be used, I guess.
patch