[Patch] Some more warnings on relations

[skyper]

First I thought about warnings for missing primary tags of relations besides type=* but then I thought that adding warnings about wrong access tags for foot and horse routes like the warnings for bicycle routes is not bad either.

Please, find attached patch​ which

• adds warnings for type=destination_sign without destination=* and type=building without building=*
• adds TRANSPORT_MODE=private to no and use_sidepath as problematic values for ways member of route=bicycle/mtb
• adds route=hiking/running/walking/fitness_trail and route=horse with inappropriate foot=* respectively horse=* to the warning above.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Revision:18193
Build-Date:2021-09-03 01:31:19
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

patch file

[Don-vip]

Do you write patches by hand? The file is named relation.mapcss, not relations.mapcss

[Don-vip]

In 18199/josm:

fix #21285 - Some more warnings on relations (patch by skyper):

• adds warnings for type=destination_sign without destination=* and type=building without building=*
• adds TRANSPORT_MODE=private to no and use_side as problematic values for ways member of route=bicycle/mtb
• adds route=hiking/running/walking/fitness_trail and route=horse with inappropriate foot=* respectively horse=* to the warning above.

[skyper]

Replying to Don-vip:

Do you write patches by hand? The file is named relation.mapcss, not relations.mapcss

Ups, sorry, typo. I use diffs and replace/rewrite the heading.

[Don-vip]

Milestone renamed

[anonymous]

Why did this patch add a warning for type=building relations without a building=* tag? As far as I understand the ​wiki, the building's outline should be tagged with building=* and not the relation itself.

[skyper]

Looks like I was too much focused to have more tags than just type=* for relations. Reading the wiki again, I think, we should remove or downgrade the warning but we need to add some tags to the member definitions in the preset, to get e.g. a warning about missing building=* on the outline member.

[skyper]

Replying to skyper:

Looks like I was too much focused to have more tags than just type=* for relations. Reading the wiki again, I think, we should remove or downgrade the warning but we need to add some tags to the member definitions in the preset, to get e.g. a warning about missing building=* on the outline member.

See #21738.