Modify

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#21480 closed defect (fixed)

[Patch] Add missing syntax hints to search dialog

Reported by: Woazboat Owned by: team
Priority: normal Milestone: 22.03
Component: Core Version:
Keywords: Cc:

Description

Hints for key?, xor as well as the explicit and search syntax are missing from the search dialog popup.

Patch to add the missing hints:
https://github.com/JOSM/josm/pull/77
https://patch-diff.githubusercontent.com/raw/JOSM/josm/pull/77.patch

Change History (18)

by Woazboat, 4 years ago

by Woazboat, 4 years ago

comment:1 by Woazboat, 4 years ago

Ignore the duplicate patch attachment (apparently there's no way to remove attachments?)

in reply to:  1 comment:2 by skyper, 4 years ago

Replying to Woazboat:

Ignore the duplicate patch attachment (apparently there's no way to remove attachments?)

Report it as spam with a nice description.

comment:3 by Woazboat, 3 years ago

ping

comment:4 by stoecker, 3 years ago

Milestone: 22.03

comment:5 by taylor.smock, 3 years ago

Resolution: fixed
Status: newclosed

In 18408/josm:

fix #21480: Add missing syntax hints to search dialog (patch by Woazboat)

This adds documentation for the following syntax:

  • key? (truthy values)
  • &, AND
  • OR
  • , XOR (only one of)

comment:6 by skyper, 3 years ago

Some mix up with XOR and ^, see #21962.

comment:7 by anonymous, 3 years ago

Typos, how I love thee...

Especially 1 character typos.

comment:8 by taylor.smock, 3 years ago

In 18412/josm:

see r18408, #21480, fix #21962: typo with xor (patch by skyper)

This fixes a typo where "logical or" should have been "logical xor".

comment:9 by Woazboat, 3 years ago

Oh, thanks for fixing that

in reply to:  9 comment:10 by taylor.smock, 3 years ago

Replying to Woazboat:

Oh, thanks for fixing that

Thank skyper for the patch. And leopoldofederico for noticing.

Typos happen to everyone (there was one recently where I had lookAt instead of lookUp, and when I was looking at my changes, I just didn't notice my typo. And I was looking for something I had done wrong).

comment:11 by stoecker, 3 years ago

In 18420/josm:

fix i18n, see #21480

comment:12 by stoecker, 3 years ago

In 18424/josm:

see #21480 - i18n fix

comment:13 by taylor.smock, 3 years ago

I feel bad about missing the mismatched '. Do we have a script somewhere in the repo to look for that?

comment:14 by stoecker, 3 years ago

Happens sometimes 🤗

I18n Jenkins task shows issues (the ones for language en are bugs in the source).

in reply to:  14 comment:15 by taylor.smock, 3 years ago

Replying to stoecker:

I18n Jenkins task shows issues (the ones for language en are bugs in the source).

That is inconvenient (it looks like it runs once daily).

comment:16 by stoecker, 3 years ago

It's enough. Usually issues are only in translated strings.

Calling "ant pot" or "ant update" (or was there even a test target somehow, see the ReadMe file for details) in i18n directory does the same, but you need a fast machine...

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.