Modify ↓

Opened 4 years ago

Closed 4 years ago

#21962 closed defect (fixed)

[Patch] Error in Search Dialog

Reported by: leopoldofederico@… Owned by: team
Priority: normal Milestone: 22.03
Component: Core Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

While I was translating I found an error in original description:

  1. logical or (one and only one expression has to be satisfied)

That is the definition for logical xor (logical xor is in 2199), not for logical or

Located in ../core/src/org/openstreetmap/josm/gui/dialogs/SearchDialog.java:349

What is the expected result?

  1. logical or (at least one expression has to be satisfied)

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Attachments (1)

josm_21962.patch​ (1017 bytes ) - added by skyper 4 years ago.
patch

Download all attachments as: .zip

Change History (5)

by skyper, 4 years ago

Attachment: josm_21962.patch​ added

patch

comment:1 by skyper, 4 years ago

Milestone: → 22.03
Summary: Error in Search Dialog → [Patch] Error in Search Dialog
Version: → latest

Looks like a typo, see #21480.
The attached patch should fix it: josm_21962.patch​

comment:2 by anonymous, 4 years ago

Thanks, that should correct it.

comment:3 by taylor.smock, 4 years ago

Thanks for noticing -- one character typos are easy to miss. (Oops)

comment:4 by taylor.smock, 4 years ago

Resolution: → fixed
Status: new → closed

In 18412/josm:

see r18408, #21480, fix #21962: typo with xor (patch by skyper)

This fixes a typo where "logical or" should have been "logical xor".

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.