Include transitive dependencies in josm-sources.jar

[Don-vip]

From ticket:20768#comment:5

problematic when using josm-sources.jar, because it lacks the sources of transitive dependencies (e.g. org.jetbrains.annotations for ch.poole.openinghoursparser).

[Don-vip]

@sebastic when I look at ​https://repo1.maven.org/maven2/ch/poole/OpeningHoursParser/0.23.4/OpeningHoursParser-0.23.4.pom, openinghoursparser does not depend on org.jetbrains.annotations?

[anonymous]

The code does, e.g.:

package ch.poole.openinghoursparser;

import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

​https://github.com/simonpoole/OpeningHoursParser/blob/master/src/main/java/ch/poole/openinghoursparser/DateRange.java

Several of the other files use the same.

[sebastic]

The dependency is also recorded in build.gradle:

dependencies {
    compileOnly 'org.jetbrains:annotations:19.0.0'
    testCompileOnly 'org.jetbrains:annotations:19.0.0'
    testCompile 'junit:junit:4.12'
}

​https://github.com/simonpoole/OpeningHoursParser/blob/master/build.gradle#L192

Issue reported upstream: ​https://github.com/simonpoole/OpeningHoursParser/issues/67

[SimonPoole]

This is a bit of a pain, but the real issue is that pom files don't have a scope that is equivalent to gradles 'compileOnly' and forcing users of the binary artifact to add a completely pointless dependency, doesn't really make sense.

I've add a comprise solution in 0.24.0 that will hopefully work, if it doesn't pls complain.

[Don-vip]

In 18079/josm:

see #21140 - upgrade to openinghoursparser 0.24.0

[Don-vip]

Thanks Simon! @sebastic are there some other missing dependencies?

[sebastic]

xmpcore for metadataextractor is another transitive dependency for which the sources need to be downloaded separately.

The recent update to 6.1.11 is also problematic because there is no source JAR for it.

[Don-vip]

Replying to sebastic:

The recent update to 6.1.11 is also problematic because there is no source JAR for it.

I've sent an e-mail to the maintainer at Adobe. Let's see.

[Don-vip]

No answer to my e-mail, I just created ​https://github.com/adobe/XMP-Toolkit-SDK/issues/41