Modify ↓

Opened 22 months ago

Last modified 21 months ago

#20898 needinfo enhancement

[WIP patch] Warn when nodes are 'merged' on geojson import

Reported by: ljdelight Owned by: ljdelight
Priority: normal Milestone:
Component: Core Version:
Keywords: import geojson colocated nodes Cc:

Description

When importing a file with nodes having the same latlon, there's different import behvior between .osm and .geojson. Sample files are attached.
The .osm imports and keeps the nodes at the same latlon as separate nodes. The .geojson import will 'merge' the nodes and may drop data.

To resolve this, the user is asked if they'd like to keep One node (keeping with how JOSM has been working) or keep all nodes (keeping with how an .osm is imported).

Attachments (4)

osm-node-same-latlon.osm​ (1.5 KB) - added by ljdelight 22 months ago.
osm-node-same-latlon.geojson​ (2.3 KB) - added by ljdelight 22 months ago.
dialog-resolve-colocated-nodes.png​ (21.8 KB) - added by ljdelight 22 months ago.
colocated-nodes.patch​ (15.2 KB) - added by ljdelight 22 months ago.

Download all attachments as: .zip

Change History (7)

Changed 22 months ago by ljdelight

Attachment: osm-node-same-latlon.osm​ added

Changed 22 months ago by ljdelight

Attachment: osm-node-same-latlon.geojson​ added

Changed 22 months ago by ljdelight

Attachment: dialog-resolve-colocated-nodes.png​ added

Changed 22 months ago by ljdelight

Attachment: colocated-nodes.patch​ added

comment:1 Changed 22 months ago by simon04

  • Please use org.openstreetmap.josm.gui.ConditionalOptionPaneUtil for the remember this/that logic
  • Naming: "co-location" is a new term currently not used in JOSM. According to ​wikipedia:Colocation, no definition precisely matches our intended usage. We have the "Duplicated nodes" test ("This test checks that there are no nodes at the very same location"). Should be reuse this term?

comment:2 Changed 22 months ago by ljdelight

Hi @simon04, I have using 'duplicated notes' and I'm looking into getting the dialog refactored to use the ConditionalOptionPaneUtil.

comment:3 Changed 21 months ago by Don-vip

Owner: changed from team to ljdelight
Status: new → needinfo
Summary: [patch] Warn when nodes are 'merged' on geojson import → [WIP patch] Warn when nodes are 'merged' on geojson import

Modify Ticket

Change Properties
Set your email in Preferences
Action
as needinfo The owner will remain ljdelight.
as The resolution will be set.
to The owner will be changed from ljdelight to the specified user.
to The owner will be changed from ljdelight to the specified user.
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from ljdelight to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.