Modify

Opened 16 months ago

Closed 9 months ago

#20393 closed enhancement (fixed)

Duplicate message for closed way with area=yes

Reported by: GerdP Owned by: Don-vip
Priority: normal Milestone: 21.08
Component: Core validator Version:
Keywords: template_report Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Have a closed way with just one tag area=yes
  2. Run validator

What is the expected result?

One warning

What happens instead?

Two messages, one from mapcss tests, the other from java test UntaggedWay

  • Untagged ways (commented) (1)
  • missing tag - incomplete object: only area (1)

Please provide any additional information below. Attach a screenshot if possible.

Do we need the java test UntaggedWays?

Build-Date:2021-01-15 16:39:45
Revision:17462
Is-Local-Build:true

Identification: JOSM/1.5 (17462 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 916 MB / 1820 MB (141 MB allocated, but free)
Java version: 1.8.0_272-b10, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:49887, -ea, -Djosm.homexxx=c:\temp\josmxxx, -javaagent:D:\eclipse-java-2020-09\eclipse\configuration\org.eclipse.osgi\215\0\.cp\lib\javaagent-shaded.jar, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Plugins:
+ ColumbusCSV (35640)
+ OpeningHoursEditor (35640)
+ apache-commons (35524)
+ buildings_tools (35669)
+ ejml (35458)
+ geotools (35458)
+ jaxb (35543)
+ jts (35458)
+ o5m (35640)
+ opendata (35640)
+ pbf (35650)
+ poly (35640)
+ reverter (35640)
+ turnlanes (35640)
+ undelete (35640)
+ utilsplugin2 (35682)

Validator rules:
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss

Attachments (0)

Change History (4)

comment:1 Changed 16 months ago by skyper

Nice example of collision with the area=*. Remove area=* and add note=* or description=* and UntaggedWay is needed. Do not know if we can change it to MapCSS with the dependency to certain memberships.

I just went one step further and got three warnings for an open way with only area=yes:

  • missing tag - incomplete object: only area
  • Unclosed way - area
  • Untagged ways (commented)
Last edited 9 months ago by Don-vip (previous) (diff)

comment:2 Changed 9 months ago by Don-vip

Description: modified (diff)

comment:3 Changed 9 months ago by Don-vip

Milestone: 21.08
Owner: changed from team to Don-vip
Status: newassigned

comment:4 Changed 9 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 18176/josm:

fix #20393 - exclude ways tagged with area=yes from UntaggedWay test

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.