Modify

Opened 7 weeks ago

Closed 6 weeks ago

Last modified 3 weeks ago

#20392 closed enhancement (fixed)

Add validator rule for shoulder

Reported by: anonymous Owned by: team
Priority: normal Milestone: 21.02
Component: Core validator Version: tested
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Add shoulder=none to way with tag highway
  2. Validate way with shoulder=none

What is the expected result?

Validator mark the way.

What happens instead?

Validator do not mark the way.

Please provide any additional information below. Attach a screenshot if possible.

See
https://wiki.openstreetmap.org/wiki/Key:shoulder
and
http://taghistory.raifer.tech/#***/shoulder/no&***/shoulder/none

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-29 02:30:53
Revision:17428
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 en) Linux Ubuntu 20.04.1 LTS
Memory Usage: 456 MB / 841 MB (186 MB allocated, but free)
Java version: 1.8.0_275-8u275-b01-0ubuntu1~20.04-b01, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1280×1024 (scaling 1.00×1.00)
Maximum Screen Size: 1280×1024
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: ubuntu:GNOME
Java package: openjdk-8-jre:amd64-8u275-b01-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
Environment variable LANG: da_DK.UTF-8
fonts-noto: fonts-noto:-
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.32)
+ OpeningHoursEditor (35640)
+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ apache-http (35589)
+ continuosDownload (91)
+ editgpx (35562)
+ ejml (35458)
+ geotools (35458)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ merge-overlap (35640)
+ o5m (35640)
+ opendata (35640)
+ pbf (35650)
+ poly (35640)
+ reverter (35640)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35674)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColourGPSData&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1

Last errors/warnings:
- 00052.743 E: Failed to locate image 'object--wire-group'
- 00053.003 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00054.737 E: Failed to locate image 'regulatory--texts--g1'
- 00054.740 E: Failed to locate image 'regulatory--texts--g2'
- 00055.203 E: Failed to locate image 'void--car-mount'
- 00055.205 E: Failed to locate image 'void--dynamic'
- 00055.207 E: Failed to locate image 'void--ego-vehicle'
- 00055.210 E: Failed to locate image 'void--ground'
- 00055.212 E: Failed to locate image 'void--static'
- 00055.880 E: Failed to locate image 'warning--kangaroo-crossing--g1'

Attachments (0)

Change History (5)

comment:2 Changed 7 weeks ago by skyper

I only get the general info warning for any value: Presets do not contain property key - Key 'shoulder' not in presets.

E.g. shoulder=* is not supported by JOSM core at all.

comment:3 Changed 6 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17469/josm:

fix #20392 - Add shoulder=* to major roads presets and warn about shoulder=none

comment:4 Changed 6 weeks ago by Klumbumbus

Milestone: 21.01

comment:5 Changed 3 weeks ago by stoecker

Milestone: 21.0121.02

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.