Opened 5 years ago

Last modified 5 years ago

#20257 closed defect

macOS build process fixes and improvements — at Version 1

Reported by: Stereo Owned by: team
Priority: normal Milestone: 21.02
Component: Installer MacOS Version:
Keywords: macos codeql github Cc: Don-vip

Description (last modified by Stereo)

I was doing this with Don-vip, but he tells me he's too busy to have a look at it this week, and to open a ticket.

https://github.com/openstreetmap/josm/pull/68 improves the macOS build process:

  • Fix macOS dock icon resetting to default one. Fetches macOS icon over https (in case we're a jar), saves 77K in the jar. (#20133)
  • Fix unreadable macOS tabs (#20075)
  • Fix macOS tested build doesn't know it's tested (#20202)
  • Better documentation of the macOS build process in the scripts, and better shell syntax
  • Allow building of a JOSM.app without having signing keys installed - useful for local builds.

Also:

  • Activate CodeQL code quality checks (not macOS-related; Don-vip and I were interested in testing it)

https://github.com/openstreetmap/josm/pull/68.diff is the raw diff.

The diff without whitespace is more readable: https://github.com/openstreetmap/josm/pull/68/files?diff=split&w=1

Change History (1)

comment:1 by Stereo, 5 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.