Modify

Opened 14 months ago

Closed 12 months ago

Last modified 7 months ago

#20257 closed defect (fixed)

macOS build process fixes and GitHub Actions improvements + CodeQL analysis

Reported by: Stereo Owned by: team
Priority: normal Milestone: 21.02
Component: Installer MacOS Version:
Keywords: macos codeql github Cc: Don-vip

Description (last modified by Stereo)

I was doing this with Don-vip, but he tells me he's too busy to have a look at it this week, and to open a ticket.

https://github.com/openstreetmap/josm/pull/68 improves the macOS build process:

  • Fix macOS dock icon resetting to default one. Fetches macOS icon over https (in case we're a jar), saves 77K in the jar. (#20133)
  • Fix unreadable macOS tabs (#20075)
  • Fix macOS tested build doesn't know it's tested (#20202)
  • Better documentation of the macOS build process in the scripts, and better shell syntax
  • Allow building of a JOSM.app without having signing keys installed - useful for local builds.

Also:

  • Activate CodeQL code quality checks (not macOS-related; Don-vip and I were interested in testing it)

https://github.com/openstreetmap/josm/pull/68.diff is the raw diff.

The diff without whitespace is more readable: https://github.com/openstreetmap/josm/pull/68/files?diff=split&w=1

Attachments (0)

Change History (20)

comment:1 Changed 13 months ago by Stereo

Description: modified (diff)

comment:2 Changed 13 months ago by stoecker

Milestone: 20.1221.01

comment:3 Changed 12 months ago by Don-vip

Milestone: 21.0121.02

comment:4 Changed 12 months ago by Stereo

Milestone: 21.0221.01

comment:5 Changed 12 months ago by Stereo

Milestone: 21.0121.02

Would it please be possible to merge these for 21.01? It's ready to go, and I want to do more interesting things than rebasing JOSM once a month to do manual builds :).

I'd be happy to merge these things myself if given access.

comment:6 Changed 12 months ago by Stereo

Milestone: 21.0221.01

comment:7 Changed 12 months ago by GerdP

My understanding is that we will not release a tested version before end of Feb.

comment:8 Changed 12 months ago by stoecker

I don't see a reason not to apply these. GerdP, can you?

comment:9 Changed 12 months ago by GerdP

In 17487/josm:

see #20257:macOS build process fixes and improvements

comment:10 Changed 12 months ago by GerdP

@Stereo: Please close the ticket if the patch fixes the problem.

comment:11 in reply to:  9 Changed 12 months ago by stoecker

Replying to GerdP:

without understanding what it does

It's ok as long as the Mac guy understands it and I hope he does ;-)

comment:12 Changed 12 months ago by GerdP

In 17488/josm:

see #20257:macOS build process fixes and improvements

  • ​fix checkstyle issues

comment:13 Changed 12 months ago by Stereo

The Mac guy hopes he understands too! :)

Thanks everyone.

comment:14 Changed 12 months ago by Stereo

Resolution: fixed
Status: newclosed

comment:15 Changed 12 months ago by stoecker

Milestone: 21.0121.02

Milestone renamed

comment:16 Changed 11 months ago by Don-vip

In 17545/josm:

see #20257 - JDK-8251377 is fixed in Java 16, make sure we don't mess with default LAF in Java 16+

comment:17 Changed 7 months ago by Don-vip

@Stereo CodeQL works nicely, and it detects some real issues, thank you!

comment:18 Changed 7 months ago by Don-vip

Keywords: codeql github added
Summary: macOS build process fixes and improvementsmacOS build process fixes and GitHub Actions improvements + CodeQL analysis

comment:19 Changed 7 months ago by Don-vip

In 17964/josm:

see #20257 - CodeQL - java/zipslip - Checks for Zip Slip Vulnerability (CWE-22 / path traversal)

comment:20 Changed 7 months ago by anonymous

@Don-vip Oh I'm glad to hear that, I'd forgotten about it! Very cool.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.