Set macOS icon on macOS startup

[Stereo]

In src/org/openstreetmap/josm/tools/PlatformHookOsx.java, line 84 updates the dock icon:

eawtApplication.getDeclaredMethod("setDockIconImage", Image.class).invoke(appli, ImageProvider.get("logo").getImage());

This sets the icon to the 'normal' icon instead of the macOS icon.

The line should be updated to read

eawtApplication.getDeclaredMethod("setDockIconImage", Image.class).invoke(appli, ImageProvider.get("JOSM-BigSur-Pencil").getImage());

The image JOSM-BigSur-Pencil.png is attached to the ticket.

[Stereo]

Oh, and this will also fix the macOS icon for people who use the jnlp (although I think it should be deprecated for macOS as it doesn't support high resolution displays, etc.)

[Don-vip]

I already added the SVG in r17319 (in nodist folder).
What should be done is update the build file so that the SVG is copied into jar file, but only for macOS build.

[Stereo]

I think it has to be png.

I can tell the build script to copy the png from nodist to the actual directory when it builds the jar, but then it won't be in the jnlp jar. Is that what we want?

[Don-vip]

Replying to Stereo:

I can tell the build script to copy the png from nodist to the actual directory when it builds the jar, but then it won't be in the jnlp jar.

Good catch. You're right, I don't want that. Other option is to not include it in jar file at all and download it from JOSM server the first time and cache it automatically (using CachedFile).

[Stereo]

CachedFile is beyond my java-fu :). Is it worth it for 77KB?

[Don-vip]

Yes. For the URL please use https://josm.openstreetmap.de/logo-macos.png I just added the rewrite rule.

[Stereo]

Fix in #20257

[stoecker]

Milestone renamed